Open
Conversation
Fatma-AlHashmi96
commented
Jul 31, 2024
Fatma-AlHashmi96
commented
- First, install Maven and add to the system environment variable, path in the variable and then, install in the appication file using command "mvn clean package -DskipTests".
- Second, create the "Dockerfile" with application name and copy the whole source file of the application into the app file.
- Third, create the "docker-compose.yaml" to take into consideration the supporting version of OpenJDK17 with Maven.
Author
|
Pull the dockerfile and docker-compose |
CodelineAtyab
requested changes
Aug 8, 2024
|
|
||
| #Copy pom.xml to current working directory | ||
| COPY pom.xml . | ||
| RUN mvn dependency:go-offline -B |
Owner
There was a problem hiding this comment.
Please add a comment, mentioning what go-offline -B would do.
Is there any benefit since we are already packaging all of the dependencies on line 13 ?
Owner
There was a problem hiding this comment.
Target directory is host specific and should not be pushed with the source code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.