Skip to content

Commit

Permalink
fixed: buttons have a discernible text
Browse files Browse the repository at this point in the history
  • Loading branch information
jeabakker committed Jul 18, 2023
1 parent df873e7 commit 9fbabec
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion views/default/form/compose/canvas.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
'#type' => 'button',
'icon' => 'plus',
'class' => 'elgg-button-action forms-compose-add-page',
'value' => elgg_echo('forms:compose:page:add'),
'text' => elgg_echo('forms:compose:page:add'),
]));

echo elgg_format_element('ul', ['class' => 'forms-compose-list'], $pages_result);
2 changes: 1 addition & 1 deletion views/default/form/compose/canvas/page.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
'#type' => 'button',
'icon' => 'plus',
'class' => 'elgg-button-action forms-compose-add-section',
'value' => elgg_echo('forms:compose:section:add'),
'text' => elgg_echo('forms:compose:section:add'),
]));

$page_title = elgg_view_icon('minus-square-regular', [
Expand Down
2 changes: 1 addition & 1 deletion views/default/form/compose/edit_field.php
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
[
'#type' => 'button',
'class' => 'elgg-button-action forms-compose-field-save',
'value' => elgg_echo('save'),
'text' => elgg_echo('save'),
],
];

Expand Down
2 changes: 1 addition & 1 deletion views/default/forms/forms/compose.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
'#type' => 'button', // don't use submit to prevent submit on enter keydown
'icon' => 'save',
'class' => 'elgg-button-submit forms-compose-save',
'value' => elgg_echo('save'),
'text' => elgg_echo('save'),
]);

elgg_set_form_footer($footer);
2 changes: 1 addition & 1 deletion views/default/forms/forms/definition/import.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

$footer = elgg_view_field([
'#type' => 'submit',
'value' => elgg_echo('import'),
'text' => elgg_echo('import'),
]);
$footer .= elgg_view_field([
'#type' => 'hidden',
Expand Down
2 changes: 1 addition & 1 deletion views/default/forms/forms/edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@

$footer .= elgg_view_field([
'#type' => 'submit',
'value' => elgg_echo('save'),
'text' => elgg_echo('save'),
]);

elgg_set_form_footer($footer);
10 changes: 4 additions & 6 deletions views/default/forms/forms/submit.php
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@

$footer .= elgg_view_field([
'#type' => 'submit',
'value' => elgg_echo('submit'),
'text' => elgg_echo('submit'),
]);
} else {
foreach ($tabs as $index => $tab) {
Expand All @@ -116,7 +116,7 @@
'elgg-button-action',
'forms-submit-buttons-prev',
],
'value' => elgg_echo('previous'),
'text' => elgg_echo('previous'),
];
}

Expand All @@ -128,20 +128,18 @@
'elgg-button-submit',
'forms-submit-buttons-next',
],
'value' => elgg_echo('next'),
'text' => elgg_echo('next'),
];
}

// submit button
if (($index + 1) === count($tabs)) {
$buttons[] = [
'#type' => 'submit',
'value' => elgg_echo('submit'),
'text' => elgg_echo('submit'),
];
}



$tabs[$index]['content'] .= elgg_view('input/fieldset', [
'class' => 'forms-submit-buttons',
'fields' => $buttons,
Expand Down
2 changes: 1 addition & 1 deletion views/default/forms/forms/validation_rules/edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
// footer
$footer = elgg_view_field([
'#type' => 'submit',
'value' => elgg_echo('save'),
'text' => elgg_echo('save'),
]);
if (!empty($name)) {
$footer .= elgg_view_field([
Expand Down

0 comments on commit 9fbabec

Please sign in to comment.