Fix wrong default subpath for string bin values#345
Open
prjanitor wants to merge 1 commit intoComandeer:mainfrom
Open
Fix wrong default subpath for string bin values#345prjanitor wants to merge 1 commit intoComandeer:mainfrom
prjanitor wants to merge 1 commit intoComandeer:mainfrom
Conversation
When package.json has a string bin value, the code was incorrectly using the package name instead of the bin string itself to construct the subpath. This caused the wrong file path to be used for the binary entry point.
Changed `./__bin__/${ name }` to `./__bin__/${ bin }` in the getBinSubPaths function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
When
package.jsonhas a stringbinvalue (e.g.,"bin": "./cli.js"), the code incorrectly used the packagenameinstead of thebinstring itself to construct the subpath. This caused the wrong file path to be used for the binary entry point.Fix
Changed line 73 in
src/packageParser/prepareDistMetadata.tsfrom:`./__bin__/${ name }`to:
`./__bin__/${ bin }`This ensures that when
binis a string, the subpath is constructed from the actual bin path value, consistent with how the object case works where each key in the bin object is used to construct the subpath.This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.