fix: resolve failing tests in gh-desktop-release-notification and gh-core-tag-notification #104

snomiao · 2025-11-05T10:22:06Z

Summary

This PR fixes test failures in GitHub Actions CI and improves test code quality with a cleaner mocking pattern.

Root Cause

The tests were failing because:

The database module (src/db/index.ts) uses top-level await to initialize MongoDB connection
Jest-style mocks (jest.mock()) were not being applied before module imports in Bun's test runner
Tests attempted to connect to MongoDB even though the database was supposed to be mocked

Changes Made

Test Infrastructure (Initial Fix)

Migrated from Jest mocks to Bun's native mocking: Replaced jest.mock() with mock.module() from bun:test
Dynamic imports: Used await import() to ensure mocks are set up before modules are loaded
MONGODB_URI environment variable: Added in src/test/msw-setup.ts to prevent production database connections

Code Quality Improvements (Refactoring)

Introduced factory pattern: Created createMockState() factory function for fresh test state
Closure-based mocking: Implemented createMockCollection() that references mockState via closure
Declarative state management: Replaced imperative mock reassignment with simple state reset in beforeEach
Per-test customization: Added findOneImpl and findOneAndUpdateImpl for easy test-specific behavior
Reduced boilerplate: Eliminated verbose manual mock function reassignments

Files Modified

app/tasks/gh-desktop-release-notification/index.spec.ts - Converted to Bun-native mocking + factory pattern
app/tasks/gh-core-tag-notification/index.spec.ts - Converted to Bun-native mocking + factory pattern
src/test/msw-setup.ts - Added MONGODB_URI environment variable for tests

Test Corrections

Fixed expected text formats to match actual implementation
Updated repo name format from `"desktop"` to `"Comfy-Org/desktop"` in assertions

Test Results

✅ All 16 tests now pass:

10 tests in gh-desktop-release-notification
6 tests in gh-core-tag-notification

```
16 pass
0 fail
23 expect() calls
Ran 16 tests across 2 files. [237.00ms]
```

Benefits of Refactoring

Less verbose: No need to reassign mock functions in `beforeEach`
More functional: State creation is pure and predictable
More flexible: Easy per-test customization without mutation
Better maintainability: Cleaner separation of concerns
Consistent pattern: Same approach across both test files

Related Issue

Fixes failing tests from: https://github.com/Comfy-Org/Comfy-PR/actions/runs/19085256036/job/54523916169

🤖 Generated with Claude Code

…core-tag-notification This commit fixes test failures that occurred due to MongoDB connection attempts during test execution. The root cause was that the database module was being imported and initialized (with top-level await) before test mocks could be applied. Changes made: 1. **Test Mocking Strategy**: Converted from jest.mock() to Bun's mock.module() with dynamic imports, ensuring mocks are set up before modules are loaded. 2. **Test Files Updated**: - app/tasks/gh-desktop-release-notification/index.spec.ts - app/tasks/gh-core-tag-notification/index.spec.ts 3. **Mock Implementation**: Replaced Jest-style mocks with Bun-native mocking patterns using tracking arrays to monitor function calls. 4. **Test Fixes**: Corrected expected text formats to match actual implementation (repo name format: "Comfy-Org/desktop" vs "desktop"). 5. **Environment Setup**: Added MONGODB_URI to test setup to prevent connection attempts to production databases during tests. All 16 tests now pass successfully without attempting MongoDB connections. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

vercel · 2025-11-05T10:22:11Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
comfy-pr	Ready	Preview	Comment	Nov 5, 2025 9:06pm

…ease-notification Replace verbose manual mock reassignment in beforeEach with a cleaner factory pattern: - Introduce createMockState() factory function to generate fresh state - Use createMockCollection() that references mockState via closure - Replace imperative mock reassignment with declarative state reset - Support per-test customization via findOneImpl/findOneAndUpdateImpl - Reduce boilerplate and improve readability Benefits: - Less verbose: no need to reassign mock functions in beforeEach - More functional: state creation is pure and predictable - More flexible: easy per-test customization without mutation - Better maintainability: cleaner separation of concerns 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

…tification Apply the same factory pattern improvements as gh-desktop-release-notification: - Introduce createMockState() factory for fresh test state - Use createMockCollection() with closure over mockState - Replace imperative reassignments with declarative state reset - Support per-test customization via findOneImpl/findOneAndUpdateImpl - Simplify beforeEach by removing manual mock function reassignments This brings consistency across the codebase and improves test maintainability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Add pull_request trigger to test workflow so tests run on PRs targeting main branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

socket-security · 2025-11-05T21:08:22Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Quality
	polyfill-text-encoder-stream@0.0.8
	is-hotkey-esm@1.0.0
	polyfill-text-decoder-stream@0.0.9
	is-ci@4.1.0
	zod-deep-partial@1.0.0
	use-swr-component@0.0.7
	react-api-doc@0.0.9
	peek-log@0.0.8
	keyv-cached-with@0.0.13
	unwind-array@1.1.4
	mail-mime-builder@0.1.0
	prettier-plugin-packagejson@2.5.19
	tailwindcss-animate@1.0.7
	sparse-bitfield@3.0.3
	random-word-slugs@0.1.7
	react-diff-viewer@3.1.1
	toml@3.0.0
	markdown-it@14.1.0
	trpc-openapi@1.2.0
	js-yaml@4.1.0
	ts-toolbelt@9.6.0
	next-auth@5.0.0-beta.30
	p-map@4.0.0 ⏵ 7.0.3	⁺¹	⁺⁴
	string-replace-loader@3.2.0
	lodash-es@4.17.21
	md5@2.3.0
	promise-all-properties@4.0.4
	use-async-effect@2.2.7
	json-stable-stringify@1.3.0
	open@10.2.0
	react-diff-view@3.3.2
	p-props@6.1.0
	react-hot-toast@2.6.0
See 38 more rows in the dashboard

View full report

socket-security · 2025-11-05T21:08:24Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Obfuscated code: npm `safer-buffer` is 94.0% likely obfuscated Confidence: 0.94 Location: Package overview From: `?` → `npm/d3@7.9.0` → `npm/safer-buffer@2.1.2` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/safer-buffer@2.1.2`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

vercel bot deployed to Preview November 5, 2025 10:24 View deployment

snomiao and others added 2 commits November 5, 2025 10:29

vercel bot deployed to Preview November 5, 2025 10:33 View deployment

ci: enable tests to run on pull requests

38d211c

Add pull_request trigger to test workflow so tests run on PRs targeting main branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

vercel bot deployed to Preview November 5, 2025 21:06 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: resolve failing tests in gh-desktop-release-notification and gh-core-tag-notification #104

fix: resolve failing tests in gh-desktop-release-notification and gh-core-tag-notification #104

Uh oh!

snomiao commented Nov 5, 2025 •

edited

Loading

Uh oh!

vercel bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Nov 5, 2025

Uh oh!

socket-security bot commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: resolve failing tests in gh-desktop-release-notification and gh-core-tag-notification #104

Are you sure you want to change the base?

fix: resolve failing tests in gh-desktop-release-notification and gh-core-tag-notification #104

Uh oh!

Conversation

snomiao commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root Cause

Changes Made

Test Infrastructure (Initial Fix)

Code Quality Improvements (Refactoring)

Files Modified

Test Corrections

Test Results

Benefits of Refactoring

Related Issue

Uh oh!

vercel bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Nov 5, 2025

Uh oh!

socket-security bot commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

snomiao commented Nov 5, 2025 •

edited

Loading

vercel bot commented Nov 5, 2025 •

edited

Loading