-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Fail-fast on prompt_worker crash (prevent “accept but not execute”) #11513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lixiang007666
wants to merge
9
commits into
Comfy-Org:master
Choose a base branch
from
lixiang007666:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−1
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6c08073
Handle prompt_worker crashes with a critical log
lixiang007666 e8d6b9a
Rename prompt_worker_crashfast to prompt_worker_failfast
lixiang007666 2fc6ddd
Update main.py
lixiang007666 eebc76e
Merge branch 'master' into master
lixiang007666 755fab5
Merge branch 'master' into master
lixiang007666 68f852a
Merge branch 'master' into master
lixiang007666 e34525e
Merge branch 'master' into master
lixiang007666 a727138
Merge branch 'master' into master
lixiang007666 539ee80
Merge branch 'master' into master
lixiang007666 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, what happens in your test case if you infinite loop here?
Instead of os._exit() if you just while(True) with your exception discard does is recover?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
In fact, by the time we reach
os._exit(), the prompt_worker thread is already no longer alive. If we replaceos._exit()withwhile True, the process won’t exit; requests will continue to be enqueued, but the queue will never be consumed.