Skip to content

Conversation

@bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Dec 31, 2025

This PR extends V3 schema and allow nodes to declare price badges using JSONata syntax.

Requires support from the Frontend repo: Comfy-Org/ComfyUI_frontend#7816

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

@bigcat88 bigcat88 force-pushed the feat/api-nodes/declarative-price-badges branch 4 times, most recently from 292d44f to dd3f1a1 Compare January 9, 2026 09:18
@bigcat88 bigcat88 force-pushed the feat/api-nodes/declarative-price-badges branch from dd3f1a1 to 5ee6f0a Compare January 10, 2026 08:18
@bigcat88 bigcat88 marked this pull request as ready for review January 11, 2026 11:00
@bigcat88 bigcat88 added the Core Core team dependency label Jan 12, 2026
Copy link
Member

@Kosinkadink Kosinkadink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and nothing broke + no spam of object_info json, merging. Actual values to be displayed once frontend PR is in is verified by QA.

@Kosinkadink Kosinkadink merged commit 1419047 into Comfy-Org:master Jan 14, 2026
16 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/declarative-price-badges branch January 20, 2026 06:07
bigcat88 added a commit to Comfy-Org/ComfyUI_frontend that referenced this pull request Jan 22, 2026
## Summary

Backend part: Comfy-Org/ComfyUI#11582

- Move API node pricing definitions from hardcoded frontend functions to
backend-defined JSONata expressions
- Add `price_badge` field to node definition schema containing JSONata
expression and dependency declarations
- Implement async JSONata evaluation with signature-based caching for
efficient reactive updates
- Show one decimal in credit badges when meaningful (e.g., 1.5 credits
instead of 2 credits)

## Screenshots (if applicable)

<!-- Add screenshots or video recording to help explain your changes -->

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7816-Move-price-badges-to-python-nodes-2da6d73d365081ec815ef61f7e3c65f7)
by [Unito](https://www.unito.io)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants