Fix: utils package shadowed by comfy/utils.py #11782
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change sys.path.insert(0, ...) to sys.path.append(...) to prevent the comfy directory from being placed at the front of sys.path. When comfy/ is at position 0, importing 'utils' finds comfy/utils.py (a module file) instead of the top-level utils/ package, causing: ModuleNotFoundError: No module named 'utils.install_util'; 'utils' is not a package This affects imports in app/frontend_management.py and app/database/db.py which import from utils.install_util. By using append() instead of insert(0, ...), the comfy directory is added at the end of sys.path, preserving normal import resolution order.
BlinkVoid
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ModuleNotFoundError: No module named 'utils.install_util'; 'utils' is not a packageerrorProblem
sys.path.insert(0, ...)innodes.pyline 22 places thecomfy/directory at the front ofsys.path. When code later importsfrom utils.install_util import ..., Python findscomfy/utils.py(a module file) instead of the top-levelutils/package.This breaks imports in:
app/frontend_management.pyapp/database/db.pyFix
Change
sys.path.insert(0, ...)tosys.path.append(...)so thecomfy/directory is added at the end ofsys.path, preserving normal import resolution order.Test plan
python main.pystarts without import errorsfrom utils.install_util import get_missing_requirements_messageworks after importingnodes