Fix ComfyUI class setup procedure (#846)

Comfy-Org · Sep 16, 2024 · 45a866f · 45a866f
1 parent 091b8a7
commit 45a866f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/scripts/ui.ts b/src/scripts/ui.ts
@@ -373,7 +373,7 @@ export class ComfyUI {
     })
 
     // For testing. Legacy ui tests don't have vue app initialized.
-    if (!app.vueAppReady) {
+    if (window['IS_TEST']) {
       this.setup(document.body)
     }
   }

diff --git a/src/scripts/ui/menu/index.ts b/src/scripts/ui/menu/index.ts
@@ -181,7 +181,9 @@ export class ComfyAppMenu {
             resizeHandler = null
           }
           document.body.style.removeProperty('display')
-          app.ui.menuContainer.style.removeProperty('display')
+          if (app.ui.menuContainer) {
+            app.ui.menuContainer.style.removeProperty('display')
+          }
           this.element.style.display = 'none'
           app.ui.restoreMenuPosition()
         }
@@ -192,7 +194,9 @@ export class ComfyAppMenu {
 
   updatePosition(v: MenuPosition) {
     document.body.style.display = 'grid'
-    this.app.ui.menuContainer.style.display = 'none'
+    if (this.app.ui.menuContainer) {
+      this.app.ui.menuContainer.style.display = 'none'
+    }
     this.element.style.removeProperty('display')
     this.position = v
     if (v === 'Bottom') {

diff --git a/tests-ui/utils/index.ts b/tests-ui/utils/index.ts
@@ -38,6 +38,7 @@ export async function start(config: StartConfig = {}): Promise<StartResult> {
 
   Object.assign(localStorage, config.localStorage ?? {})
   document.body.innerHTML = html.toString()
+  window['IS_TEST'] = true
 
   mockApi(config)
   mockSettingStore()