Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix husky pre-commit & type check only staged #1361

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Fix husky pre-commit & type check only staged #1361

merged 3 commits into from
Oct 29, 2024

Conversation

webfiltered
Copy link
Contributor

Does what it says on the commits.

  • Fix husky pre-commit on some Windows clients
  • Limit commit type check to staged files
  • Remove deprecated git add from lint-staged

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/tsc-files@1.1.4 None 0 5.15 kB gustavopch

View full report↗︎

huchenlei
huchenlei reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this respect tsc-strict? I added that precommit hook to make sure the strict check passes for each commit.

@huchenlei
Copy link
Member

huchenlei commented Oct 29, 2024 •
edited
Loading

Anyway, we shall still see the ts-strict error via the CI test.

@huchenlei huchenlei merged commit 795e932 into main Oct 29, 2024
9 checks passed
@huchenlei huchenlei deleted the pre-commit branch October 29, 2024 18:15
@webfiltered
Copy link
Contributor Author

It respects tsconfig, but probably does not do the per-file strict check since it's not part of typescript. Build will also still fail.

@huchenlei huchenlei mentioned this pull request Nov 15, 2024
Closed
huchenlei added a commit that referenced this pull request Nov 15, 2024
@huchenlei
Revert "Fix husky pre-commit & type check only staged (#1361)"
7518de6 
This reverts commit 795e932.
@huchenlei huchenlei mentioned this pull request Nov 15, 2024
Merged
huchenlei added a commit that referenced this pull request Nov 15, 2024
@huchenlei
Revert "Fix husky pre-commit & type check only staged" (#1550)
791a256 
* Revert "Fix husky pre-commit & type check only staged (#1361)"

This reverts commit 795e932.

* Update package.json
@webfiltered webfiltered mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei