[Electron] Allow users to submit error reports #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
reviewed
Nov 21, 2024
| if (submitting.value) return | ||
| submitting.value = true | ||
| try { | ||
| await electronAPI().sendErrorToSentry(error.exception_message, { |
There was a problem hiding this comment.
@robinjhuang PTAL. I am not very sure if this is the correct format we are expecting in the Sentry setup.
There was a problem hiding this comment.
Slack chat from @robinjhuang
Can we send the logs and system info in the report as well? Everything except the workflow for now would be good i think
Remove unused import
huchenlei
approved these changes
Nov 21, 2024
robinjhuang
requested changes
Nov 22, 2024
|
Offline discussion: we go with basic stacktrace now, and potentially strip out the user base directory that might potentially contain user name. (Happen in electron side) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Send Report button to the execution error dialog to allow users to report errors.
This submits the error message, stacktrace and node type.
We can extend this in future to allow opting in to include more details if they are found to be useful for diagnosing issues (e.g. logs, installed nodes, version, etc)