Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] ComfyUI server config (Launch args config) #1644

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Nov 22, 2024

Summary

This PR adds setting panel for configuring ComfyUI's main.py arguments. Note this feature is currently for electron only and some arguments such as directory arguments and frontend version argument are not included because they are either used by the electron app directly or will cause issue if not properly controlled.

image

New settings

Comfy.Server.LaunchArgs stores the command format to be read by the electron app, while Comfy.Server.ServerConfigValues stores the value used for frontend display.

image

Follow-up

Add an extra panel to show the launch args used on the UI.

@huchenlei huchenlei added the Electron ComfyUI Desktop related label Nov 22, 2024
@huchenlei huchenlei merged commit 4007cc1 into main Nov 22, 2024
10 checks passed
@huchenlei huchenlei deleted the server_config branch November 22, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electron ComfyUI Desktop related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant