Sync pr fix clip path when using new menu #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pythongosssss Shall I close this as the main repo PR is closed? comfyanonymous/ComfyUI#4073 |
|
Sorry forgot about this one, should be ready for review now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comfyanonymous/ComfyUI#4073
Fixes clip-path calculation when using new menu
#104
For a more extensive fix, I've done a prototype here:
comfyanonymous/ComfyUI@master...pythongosssss:ComfyUI:prototype-litegraph-support-domwidgets
Splitting each LiteGraph node into its own canvas so DOM elements are able to position themselves in the z-index relative to their owner node, will need a bunch more fixing of bits of rendering (e.g. selection outline/shadows/etc) and not sure what impact it'll have on performance.