Fix double trigger of loadColorPalette effect #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
commented
Jan 1, 2025
| @@ -672,7 +672,11 @@ export const CORE_SETTINGS: SettingParams[] = [ | |||
| name: 'The active color palette id', | |||
| type: 'hidden', | |||
| defaultValue: 'dark', | |||
| versionModified: '1.6.7' | |||
| versionModified: '1.6.7', | |||
| migrateDeprecatedValue(value: string) { | |||
There was a problem hiding this comment.
Previously custom color palettes' id was prefixed with custom_ when persisted to settings.
| @@ -180,7 +179,7 @@ export const useColorPaletteService = () => { | |||
| return { | |||
| addCustomColorPalette: wrapWithErrorHandling(addCustomColorPalette), | |||
| deleteCustomColorPalette: wrapWithErrorHandling(deleteCustomColorPalette), | |||
| loadColorPalette: wrapWithErrorHandling(loadColorPalette), | |||
| loadColorPalette: wrapWithErrorHandlingAsync(loadColorPalette), | |||
There was a problem hiding this comment.
Fix error handling of async func.
huchenlei
added
the
New Browser Test Expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settingStore.get('Comfy.colorPalette'): Raw setting value. Can be contain invalid id. When changed, triggerloadColorPalettecolorPaletteStore.activeColorPaletteId: The valid id of the current active palette, always not null.┆Issue is synchronized with this Notion page by Unito