Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable missing models dialog by default #2345

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Jan 25, 2025

This PR sets the default value of "Comfy.Workflow.ShowMissingModelsWarning" to true. This setting enables the below dialog when loading workflows that have a models field (assuming the user doesn't have the model):

Selection_814

Examples of workflows with model fields can be found in the templates folder of the frontend repo (added in #1076). The format is like this:

    "models": [
      {
        "name": "flux1-schnell-fp8.safetensors",
        "url": "https://huggingface.co/Comfy-Org/flux1-schnell/resolve/main/flux1-schnell-fp8.safetensors?download=true",
        "directory": "checkpoints"
      }
    ],

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner January 25, 2025 05:03
@huchenlei huchenlei merged commit c5d153c into main Jan 25, 2025
10 checks passed
@huchenlei huchenlei deleted the enable-missing-models-default branch January 25, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants