Fix copy paste of widget value #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
added
the
New Browser Test Expectations
huchenlei
added
New Browser Test Expectations
huchenlei
added a commit
that referenced
this pull request
Aug 3, 2024
* Fix canvas not init issue (#283) * Fix copy paste of widget value (#284) * Fix copy paste of widget value * Fix ui tests * Allow undefined group font size * Update test expectations [skip ci] * nit --------- Co-authored-by: github-actions <github-actions@github.com> * 1.2.9 (#285) * WIP * Add refresh button * Add context menu * nit * Add selection mode * Editable text * Fix relative path * implement node delete * Dynamic menu items * Fix refresh * Better dynamic handling of menu items * Disable rename / delete for root * Add workflow download * Auto select file name * Create workflow * Generate non-dup name * Fix folder name * Rename workflwoStore to userFileStore * load workflow when leaf node selected * Extract common report error logic * Basic workflows tab test * Auto expand * Add test on add/remove workflow --------- Co-authored-by: github-actions <github-actions@github.com>
huchenlei
added a commit
that referenced
this pull request
Aug 4, 2024
* Fix canvas not init issue (#283) * Fix copy paste of widget value (#284) * Fix copy paste of widget value * Fix ui tests * Allow undefined group font size * Update test expectations [skip ci] * nit --------- Co-authored-by: github-actions <github-actions@github.com> * 1.2.9 (#285) * WIP * Add refresh button * Add context menu * nit * Add selection mode * Editable text * Fix relative path * implement node delete * Dynamic menu items * Fix refresh * Better dynamic handling of menu items * Disable rename / delete for root * Add workflow download * Auto select file name * Create workflow * Generate non-dup name * Fix folder name * Rename workflwoStore to userFileStore * load workflow when leaf node selected * Extract common report error logic * Basic workflows tab test * Auto expand * Add test on add/remove workflow --------- Co-authored-by: github-actions <github-actions@github.com>
huchenlei
added a commit
that referenced
this pull request
Aug 5, 2024
* Fix canvas not init issue (#283) * Fix copy paste of widget value (#284) * Fix copy paste of widget value * Fix ui tests * Allow undefined group font size * Update test expectations [skip ci] * nit --------- Co-authored-by: github-actions <github-actions@github.com> * 1.2.9 (#285) * WIP * Add refresh button * Add context menu * nit * Add selection mode * Editable text * Fix relative path * implement node delete * Dynamic menu items * Fix refresh * Better dynamic handling of menu items * Disable rename / delete for root * Add workflow download * Auto select file name * Create workflow * Generate non-dup name * Fix folder name * Rename workflwoStore to userFileStore * load workflow when leaf node selected * Extract common report error logic * Basic workflows tab test * Auto expand * Add test on add/remove workflow --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the workflow validation to load of graph as in many other places, such as on paste, the parse is just to check whether the string is a JSON.
Previously copy of widget value would trigger an zod validation error alert. This PR adds a playwright test to reproduce that.