Remove fetch-templates script #3500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
reviewed
Apr 18, 2025
There was a problem hiding this comment.
Is checkout templates still needed after comfyanonymous/ComfyUI#7623?
Won't the templates be get setup via pip package when we install ComfyUI's requirements?
christian-byrne
force-pushed
the
remove-templates-script
branch
from
862cac4 to
cdc99b6
Compare
No, I mistakenly thought there was an issue because I had To fix the tests that check all thumbnails exist, change to requesting the resources from the server, rather than checking they exist via |
huchenlei
approved these changes
Apr 19, 2025
christian-byrne
added a commit
to Comfy-Org/litegraph.js
that referenced
this pull request
Apr 19, 2025
christian-byrne
added a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates are now included in ComfyUI directly via
comfyui-template-workflowspip package.Resolves #3503
┆Issue is synchronized with this Notion page by Unito