[feat] Add auto-refresh on task completion for RemoteWidget nodes #4191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
force-pushed
the
load-outputs-auto-refresh
branch
from
d2bb38c to
d7f8834
Compare
webfiltered
requested changes
Jun 16, 2025
Comment on lines
229
to
232
| let taskWatcher: ReturnType<typeof useTaskCompletionWatcher> | null = null | ||
|
|
||
| // Initialize task completion watcher | ||
| taskWatcher = useTaskCompletionWatcher({ |
There was a problem hiding this comment.
Looks like this is just immediate reassignment?
Suggested change
| let taskWatcher: ReturnType<typeof useTaskCompletionWatcher> | null = null | |
| // Initialize task completion watcher | |
| taskWatcher = useTaskCompletionWatcher({ | |
| // Initialize task completion watcher | |
| const taskWatcher = useTaskCompletionWatcher({ |
Comment on lines
248
to
250
| taskWatcher?.start() | ||
| } else { | ||
| taskWatcher?.stop() |
There was a problem hiding this comment.
Suggested change
| taskWatcher?.start() | |
| } else { | |
| taskWatcher?.stop() | |
| taskWatcher.start() | |
| } else { | |
| taskWatcher.stop() |
|
|
||
| // Cleanup on node removal | ||
| node.onRemoved = useChainCallback(node.onRemoved, function () { | ||
| taskWatcher?.stop() |
There was a problem hiding this comment.
Suggested change
| taskWatcher?.stop() | |
| taskWatcher.stop() |
Comment on lines
234
to
236
| onComplete: () => { | ||
| if (widget.refresh) { | ||
| widget.refresh() | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| onComplete: () => { | |
| if (widget.refresh) { | |
| widget.refresh() | |
| } | |
| } | |
| onComplete: () => widget.refresh?.() |
| start() | ||
| } | ||
|
|
||
| onUnmounted(() => stop()) |
There was a problem hiding this comment.
Suggested change
| onUnmounted(() => stop()) | |
| onUnmounted(stop) |
nit: perf
christian-byrne
commented
Jun 16, 2025
|
Does this only need to run for output nodes? |
|
It should run when the workflow is done executing. |
Implements auto-refresh functionality that triggers when tasks complete for any RemoteWidget node. Users can toggle the feature on/off via a boolean widget labeled "Auto-refresh on task completion". Key components: - useTaskCompletionWatcher: Reusable composable that watches queue history to detect task completion - RemoteWidget enhancement: Automatically adds toggle widget to all remote widgets - Comprehensive test coverage for both composables Fixes #4153
…ctations - Changed default value from true to false - Added 'on' and 'off' labels for the toggle states - Ensures consistency with existing widget patterns
- Removed expectation for 'on' and 'off' properties in test - Aligns test with actual implementation after label removal
…vent - Remove complex task completion watcher composable - Use WebSocket 'execution_success' event for workflow completion detection - Much simpler implementation (~35 lines vs ~100+ lines) - Update widget label to "Auto-refresh after generation" - Add debug logging for execution success handler
- Update test to expect "Auto-refresh after generation" label - All tests now passing
christian-byrne
force-pushed
the
load-outputs-auto-refresh
branch
from
c238abf to
500b84c
Compare
webfiltered
approved these changes
Jun 18, 2025
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements auto-refresh toggle button for nodes with remote widgets. When enabled, automatically refreshes the widget when the workflow completes execution.
auto-refresh-node-demo.mp4
Implementation Details:
execution_successevent to detect workflow completionTest Plan:
Fixes #4153
┆Issue is synchronized with this Notion page by Unito