Skip to content

[3d] better solution to support reading extra resource/texture #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jtydhr88
Copy link
Collaborator

@jtydhr88 jtydhr88 commented Jun 17, 2025

just find out a correct way to handle extra resource/texture reading for 3d model, rather than writting an override class.
Tested on:
OBJ+MTL
image

GLTF+Extra Texture
image

FBX+Extra Texture
image

Resolved #4101

┆Issue is synchronized with this Notion page by Unito

@jtydhr88 jtydhr88 requested a review from a team as a code owner June 17, 2025 01:57
Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go w/nits!

@jtydhr88 jtydhr88 requested a review from webfiltered June 19, 2025 00:51
@jtydhr88
Copy link
Collaborator Author

jtydhr88 commented Jun 19, 2025

After a period of testing, I found that in order to better implement this texture modification, we still need to support uploading models and their corresponding resources to different folders. Previously, all model files would be uploaded to the '3d' folder, and during the upload process, files with duplicate names would be automatically renamed. As for resource files, they needed to be manually copied to the 3d folder, which created a problem where files with the same names would be overwritten. Therefore, a better approach is to allow users to upload different models and their corresponding resources to different subfolders. This is the change implemented in this PR.
Demo is

2025-06-20.04-56-34.mp4

need BE change comfyanonymous/ComfyUI#8597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Load3D loading issues
2 participants