Dom widget playwright tests #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just so i can local dev with playwright without git cluttering up
mcmonkey4eva
added
the
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
removed
the
New Browser Test Expectations
mcmonkey4eva
added
the
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
this function is never called so it's fine
otherwise it's a double click
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
changed the title
huchenlei
approved these changes
Aug 20, 2024
| @@ -34,6 +34,7 @@ tests-ui/workflows/examples | |||
| /playwright-report/ | |||
| /blob-report/ | |||
| /playwright/.cache/ | |||
| browser_tests/*/*-win32.png | |||
There was a problem hiding this comment.
I should probably batch remove the win32 expectations as they are no longer maintained.
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playwright tests for dom widget proper handling - implements request @ #475 (review)
PR is opened early so I can get the github actions bot to run, not yet ready for mergeReady to go.I apologize for the mess. Please use github squash button when merging lol.
pannedimage being slightly changed is intentional, made a change to how positional offsets are calculated for thepanfunction (to be relative)Includes a temporary hackaround for a bug with the node search menu -- it will open any time the mouse is pressed twice rapidly, even if the mouse was actively doing things in that time (eg panning the canvas) - I was able to easily replicate this in the regular UI, not just confined to testing, so that needs to be fixed (at which point that hack can be removed)