Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating menu option #726

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Floating menu option #726

merged 7 commits into from
Sep 16, 2024

Conversation

pythongosssss
Copy link
Member

Adds a new option for the menu with workflow management at the top and the graph actions in bottom center, which should be better for people with ultrawide monitors, with less distance to move the mouse for queuing.

image

src/scripts/ui/menu/index.ts Show resolved Hide resolved
src/services/autoQueueService.ts Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
@SirVeggie
Copy link
Contributor

I think it would make sense for this to be repositionable with a drag handle.

@silveroxides
Copy link

Isn't the workflow management menu also part of the current top/bottom bar? It would make more sense to have the floating menus buttons stacked vertically or be switchable. As there is more screens space to make use of that way. Frontend is after all supposed to be targeting desktop browsers firstly which means there is far more usable space on the left and right side.

[« | ▶️Generate|❌]
[🔄 | 📋 | 🔳 | 🚫]
[⏏️Workflows | 💾]

@huchenlei
Copy link
Member

@pythongosssss Gentle ping on the tests.

@huchenlei huchenlei changed the base branch from main to dev1.3 September 16, 2024 02:27
@huchenlei huchenlei merged commit a5fca90 into dev1.3 Sep 16, 2024
9 checks passed
@huchenlei huchenlei deleted the floating-menu branch September 16, 2024 02:28
huchenlei pushed a commit that referenced this pull request Sep 17, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 17, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 17, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 17, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 17, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 18, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 19, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 19, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 20, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 22, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 22, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 23, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 24, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 25, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
huchenlei pushed a commit that referenced this pull request Sep 25, 2024
* Add floating menu

* Fix

* Updates

* Add auto-queue change test

* Fix
@dchatel
Copy link

dchatel commented Sep 26, 2024

I really don't like it. There should be an option to put it back where it was. Just to be clear :
First of all, there are a lot of free space in the top right corner of the UI. And with that floating button, that space is completely wasted now.
image

Second, here is what an OS (windows, linux, whatever) would look like if they adopted this design:
image

There may be people who like the floating design, and I respect that. But screen space is something that should be saved when possible, not wasted, especially in an app like ComfyUI where you need to plan what you are doing if you want to create "working views" in your workflow.
The floating menu defeat that and hides important parts of the workflow, forcing the user to move the graph around over and over again.

The worst of this situation, in my opinion, is that there's a lot of free available screen space in the top right corner that is now completely useless.

Look how it could be:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants