Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging setting's display name #742

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix logging setting's display name #742

merged 1 commit into from
Sep 5, 2024

Conversation

christian-byrne
Copy link
Collaborator

This setting field was using its ID as its display name:

Selection_317

After:

Selection_318

The settingID was also being explicitly set as string type, which makes it not an element of keyof Settings

huchenlei
huchenlei approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huchenlei huchenlei merged commit 743683c into Comfy-Org:main Sep 5, 2024
6 checks passed
@christian-byrne christian-byrne deleted the fix-logging-setting-display branch September 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christian-byrne @huchenlei