Skip to content

Conversation

@jimlee2048
Copy link

@jimlee2048 jimlee2048 commented Dec 16, 2025

⚠️ Note: This PR and code were generated with help from GPT‑5.2. I have NO frontend dev experience, so this should be considered a prototype for discussion. Please evaluate carefully before merging; if changes are needed, I may need maintainer guidance to apply them correctly.


Summary

Improve the multi-user login experience by replacing the existing-user dropdown with a searchable, keyboard-friendly user picker that scales better with long user lists.

Changes

  • What:
    • Update UserSelectView to use an autocomplete-style selector for existing users (type to filter, arrow keys + Enter to select, dropdown button supported).
    • Reuse the repo’s existing fuzzy search utilities to filter usernames locally.
    • Enhance AutoCompletePlus with opt-in props to avoid PrimeVue overlay/focus edge cases in this login flow:
    • Keep the dropdown open and show all users when the input is cleared.
    • Blur the input after a user is selected while preserving the selected value (mouse and Enter selection).
    • Add unit tests covering the new behavior and the PrimeVue edge cases guarded by the new opt-in props.

Review Focus

  • AutoCompletePlus opt-in behavior (keepOpenOnEmptyInput, blurOnOptionSelect) and whether the internal overrides are acceptable for upstream maintenance (they are disabled by default and only enabled on the multi-user login view).
  • User selection behavior when typing partial matches and selecting via Enter vs mouse (no clearing, no flicker).
  • Test coverage and whether the new component-level tests are sufficient.

Fixes #7555

Screenshots (if applicable)

demo.mp4

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🎨 Storybook Build Status

loading Build is starting...

⏰ Started at: 12/16/2025, 02:26:04 PM UTC

🚀 Building Storybook

  • 📦 Installing dependencies...
  • 🔧 Building Storybook components...
  • 🌐 Preparing deployment to Cloudflare Pages...

⏱️ Please wait while the Storybook build is in progress...

@github-actions
Copy link

🎭 Playwright Test Results

loading Tests are starting...

⏰ Started at: 12/16/2025, 02:26:04 PM UTC

🚀 Running Tests

  • 🧪 chromium: Running tests...
  • 🧪 chromium-0.5x: Running tests...
  • 🧪 chromium-2x: Running tests...
  • 🧪 mobile-chrome: Running tests...

⏱️ Please wait while tests are running...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] Searchable existing-user selector on multi-user login

1 participant