Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix searchbox popover on touch devices #773

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Sep 9, 2024

Issue: Opening search on touch device immediately selects search item if initiating event is same location as searchbox.

mobile-search-bug.mp4

Alternative solutions:

  • Capture clicks on AutoComplete component/children (but cannot prevent primevue click handlers that are registered first - fails when click is on component root and not a child that can capture)
  • Add delay to option-select handler (but doesn't prevent UI side effects from other click handlers)

@christian-byrne christian-byrne marked this pull request as ready for review September 9, 2024 13:23
@huchenlei huchenlei merged commit 1575810 into main Sep 10, 2024
6 checks passed
@huchenlei huchenlei deleted the search-popover-mobile branch September 10, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants