Skip to content

Commit

Permalink
add numpy<2 override on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
telamonian committed Aug 30, 2024
1 parent 9a2e052 commit 54386d9
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion comfy_cli/uv.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
from typing import Any, Optional, Union, cast

from comfy_cli import ui
from comfy_cli.constants import GPU_OPTION
from comfy_cli.constants import GPU_OPTION, OS
from comfy_cli.typing import PathLike
from comfy_cli.utils import get_os


def _run(cmd: list[str], cwd: PathLike, check: bool = True) -> subprocess.CompletedProcess[Any]:
Expand Down Expand Up @@ -72,6 +73,7 @@ class DependencyCompiler:
# ensure usage of {gpu} version of pytorch
--extra-index-url {gpuUrl}
torch
torchaudio
torchsde
torchvision
"""
Expand Down Expand Up @@ -397,6 +399,11 @@ def make_override(self):
f.write(DependencyCompiler.overrideGpu.format(gpu=self.gpu, gpuUrl=self.gpuUrl))
f.write("\n\n")

# TODO: remove numpy<2 override once torch is compatible with numpy>=2
if get_os() == OS.WINDOWS:
f.write("numpy<2\n")
f.write("\n\n")

completed = DependencyCompiler.Compile(
cwd=self.cwd,
reqFiles=self.reqFilesCore,
Expand Down

0 comments on commit 54386d9

Please sign in to comment.