refactor completer

update node completer cache in `comfy update`

comfy_cli/cmdline.py

@@ -252,7 +252,13 @@ def install(
 
 @app.command(help="Update ComfyUI Environment [all|comfy]")
 @tracking.track_command()
-def update(target: str = typer.Argument("comfy", help="[all|comfy]")):
+def update(
+    target: str = typer.Argument(
+        "comfy",
+        help="[all|comfy]",
+        autocompletion=utils.create_choice_completer(["all", "comfy"]),
+    )
+):
     if target not in ["all", "comfy"]:
         typer.echo(
             f"Invalid target: {target}. Allowed targets are 'all', 'comfy'.",
@@ -277,6 +283,8 @@ def update(target: str = typer.Argument("comfy", help="[all|comfy]")):
             check=True,
         )
 
+    custom_nodes.command.update_node_id_cache()
+
 
 # @app.command(help="Run workflow file")
 # @tracking.track_command()

comfy_cli/command/custom_nodes/command.py

@@ -9,7 +9,7 @@
 from rich import print
 from typing_extensions import List, Annotated
 
-from comfy_cli import ui, logging, tracking
+from comfy_cli import ui, logging, tracking, utils
 from comfy_cli.config_manager import ConfigManager
 from comfy_cli.file_utils import (
     download_file,
@@ -168,8 +168,9 @@ def clear(path: str):
     execute_cm_cli(["clear", path])
 
 
-def show_completer(incomplete: str) -> list[str]:
-    valid_choices = [
+# completers
+show_completer = utils.create_choice_completer(
+    [
         "installed",
         "enabled",
         "not-installed",
@@ -178,17 +179,15 @@ def show_completer(incomplete: str) -> list[str]:
         "snapshot",
         "snapshot-list",
     ]
-    return [choice for choice in valid_choices if choice.startswith(incomplete)]
+)
 
 
-def mode_completer(incomplete: str) -> list[str]:
-    modes = ["remote", "local", "cache"]
-    return [mode for mode in modes if mode.startswith(incomplete)]
+mode_completer = utils.create_choice_completer(["remote", "local", "cache"])
 
 
-def channel_completer(incomplete: str) -> list[str]:
-    channels = ["default", "recent", "dev", "forked", "tutorial", "legacy"]
-    return [channel for channel in channels if channel.startswith(incomplete)]
+channel_completer = utils.create_choice_completer(
+    ["default", "recent", "dev", "forked", "tutorial", "legacy"]
+)
 
 
 def node_completer(incomplete: str) -> list[str]:

comfy_cli/utils.py

@@ -57,3 +57,10 @@ def is_running(pid):
         return True
     except psutil.NoSuchProcess:
         return False
+
+
+def create_choice_completer(opts):
+    def f(incomplete: str) -> list[str]:
+        return [opt for opt in opts if opt.startswith(incomplete)]
+
+    return f