Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error for upload_file_to_signed_url function #228

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

yoland68
Copy link
Member

@yoland68 yoland68 commented Jan 3, 2025

  • Cleaned up the upload_file_to_signed_url function and raising exceptions for errors.
  • Added a new test suite for file_utils that checks the upload_file_to_signed_url function in different scenarios, both successful and failing.
  • Updated tests in test_publish.py for failures when using the publish command.

@yoland68 yoland68 merged commit 98bfef7 into main Jan 3, 2025
7 of 11 checks passed
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 44.79% <100.00%> (+1.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/file_utils.py 67.04% <100.00%> (+50.91%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant