Configure number of synchronised products in Channel configuration #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
reviewed
Apr 9, 2024
| @@ -5,3 +5,8 @@ sylius_ui: | |||
| commerce_weavers_sylius_also_bought_missing_configuration: | |||
| template: '@CommerceWeaversSyliusAlsoBoughtPlugin/_missing_configuration.html.twig' | |||
| priority: 40 | |||
| sylius.admin.channel.form.second_column_content: | |||
| blocks: | |||
| commerce_weavers_sylius_also_bought_number_of_synchronised_products: | |||
There was a problem hiding this comment.
Suggested change
| commerce_weavers_sylius_also_bought_number_of_synchronised_products: | |
| commerce_weavers_sylius_also_bought_number_of_synchronized_products: |
just because in different places, we already use the US version with z
There was a problem hiding this comment.
same for twig tempalte file name etc.
There was a problem hiding this comment.
Let me change that in a separate PR, as it would require also changing the property name and a bunch of other stuff :D
| { | ||
| /** @ORM\Column(name="number_of_synchronised_products", type="integer", nullable=false, options={"default": 10}) */ | ||
| #[ORM\Column(name: 'number_of_synchronised_products', type: 'integer', nullable: false, options: ['default' => 10])] | ||
| private int $numberOfSynchronisedProducts = 10; |
There was a problem hiding this comment.
Suggested change
| private int $numberOfSynchronisedProducts = 10; | |
| private int $numberOfSynchronizedProducts = 10; |
Zales0123
force-pushed
the
number-in-configuration
branch
from
b3ba035
to
94d8dbf
Compare
Agreed 👍 let's do it in a separate PR, ok? 💃 |
NoResponseMate
approved these changes
Jul 29, 2024
lchrusciel
approved these changes
Jul 29, 2024
|
Great job, @Zales0123! 🏅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
TODO: