Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved MarqueeText code quality #477

Merged
merged 8 commits into from
Jul 19, 2023

Conversation

Avid29
Copy link
Contributor

@Avid29 Avid29 commented Jul 18, 2023

This change should have no behavioral differences. Just code style.

Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, looks good otherwise!

components/MarqueeText/src/MarqueeText.cs Outdated Show resolved Hide resolved
components/MarqueeText/src/MarqueeText.cs Outdated Show resolved Hide resolved
components/MarqueeText/src/MarqueeText.cs Outdated Show resolved Hide resolved
components/MarqueeText/src/MarqueeText.cs Outdated Show resolved Hide resolved
components/MarqueeText/src/MarqueeText.cs Outdated Show resolved Hide resolved
components/MarqueeText/src/MarqueeText.cs Outdated Show resolved Hide resolved
components/MarqueeText/src/MarqueeText.cs Outdated Show resolved Hide resolved
components/MarqueeText/src/MarqueeText.cs Show resolved Hide resolved
Co-authored-by: Arlo <arlo.godfrey@outlook.com>

Updated MarqueeText.cs

Co-authored-by: Arlo <arlo.godfrey@outlook.com>

Update MarqueeText.cs

Co-authored-by: Arlo <arlo.godfrey@outlook.com>

Update MarqueeText.cs

Co-authored-by: Arlo <arlo.godfrey@outlook.com>

Update components/MarqueeText/src/MarqueeText.cs

Co-authored-by: Arlo <arlo.godfrey@outlook.com>

Update components/MarqueeText/src/MarqueeText.cs

Co-authored-by: Arlo <arlo.godfrey@outlook.com>

Update components/MarqueeText/src/MarqueeText.cs

Co-authored-by: Arlo <arlo.godfrey@outlook.com>
@Arlodotexe Arlodotexe merged commit 1a345a8 into CommunityToolkit:main Jul 19, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants