Tooling Update #554
Merged
Tooling Update #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SDK release notes and mark as experimental
|
Ugh, just noticed TitleBar is missing the Labs Icon and has the default X one...
|
Arlodotexe
approved these changes
Jun 28, 2024
|
Cool, we got a clean build, so I'll merge. Can open a PR for anything else like the TitleBar samples messing the TitleBar of the app issue I saw. Not sure if that's unique to trying to merge them together or will repro in the Labs all-samples gallery build too within just the single repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we haven't updated the tooling pointer in a while?
At least was out-of-sync on my machine.
Also had some minor tweaks to make to the TitleBar docs.
Though think we still don't display these great in the sample app, will take a look as I build it. See CommunityToolkit/Tooling-Windows-Submodule#70