Updated to WinAppSdk 1.6, fixed AoT annotations #561

Arlodotexe · 2024-08-07T23:25:21Z

Prerequisite PR: CommunityToolkit/Tooling-Windows-Submodule#195

Arlodotexe · 2024-08-07T23:46:58Z

I'm seeing these errors in the MarqueeText and MarkdownTextBlock components, in places where TextDecorations is used:

"V:\Labs-Windows\tooling\ProjectHeads\AllComponents\wasdk\CommunityToolkit.App.Wasdk.csproj" (Clean;Build target) (1:7) ->
"V:\Labs-Windows\components\MarkdownTextBlock\src\CommunityToolkit.WinUI.Controls.MarkdownTextBlock.csproj" (default target) (12:31) ->(XamlPreCompile target) ->
V:\Labs-Windows\components\MarkdownTextBlock\src\TextElements\MyEmphasisInline.cs(67,33): error CS0433: The type 'TextDecorations' exists in both 'Microsoft.WinUI, Version=3.0.0.0, Culture=neutral, PublicKeyToken=de31ebe4ad15742b' and 'Microsoft.Windows.UI.Xaml, Version=10.0.22621.35, Culture=neutral, PublicKeyToken=31bf3856ad364e35' [V:\Labs-Windows\components\MarkdownTextBlock\src\CommunityToolkit.WinUI.Controls.MarkdownTextBlock.csproj::TargetFramework=net8.0-windows10.0.22621.0]

"V:\Labs-Windows\tooling\ProjectHeads\AllComponents\wasdk\CommunityToolkit.App.Wasdk.csproj" (Clean;Build target) (1:7) ->
"V:\Labs-Windows\components\MarqueeText\src\CommunityToolkit.Labs.WinUI.MarqueeText.csproj" (default target) (6:31) ->
V:\Labs-Windows\components\MarqueeText\src\MarqueeText.Properties.cs(102,12): error CS0433: The type 'TextDecorations' exists in both 'Microsoft.WinUI, Version=3.0.0.0, Culture=neutral, PublicKeyToken=de31ebe4ad15742b' and 'Microsoft.Windows.UI.Xaml, Version=10.0.22621.35, Culture=neutral, PublicKeyToken=31bf3856ad364e35' [V:\Labs-Windows\components\MarqueeText\src\CommunityToolkit.Labs.WinUI.MarqueeText.csproj::TargetFramework=net8.0-windows10.0.22621.0]

If you try to fix the issue using Microsoft.Windows.UI.Xaml.TextDecorations, you get CS0234 "type or namespace does not exist in namespace":

"V:\Labs-Windows\tooling\ProjectHeads\AllComponents\wasdk\CommunityToolkit.App.Wasdk.csproj" (Clean;Build target) (1:7) ->
"V:\Labs-Windows\components\MarkdownTextBlock\src\CommunityToolkit.WinUI.Controls.MarkdownTextBlock.csproj" (default target) (9:31) -> (XamlPreCompile target) ->
V:\Labs-Windows\components\MarkdownTextBlock\src\TextElements\MyEmphasisInline.cs(67,33): error CS0234: The type or namespace name 'UI' does not exist in the namespace 'Microsoft.Windows' (are you missing an assembly reference?) [V:\Labs-Windows\components\MarkdownTextBlock\src\CommunityToolkit.WinUI.Controls.MarkdownTextBlock.csproj::TargetFramework=net8.0-windows10.0.22621.0]

"V:\Labs-Windows\tooling\ProjectHeads\AllComponents\wasdk\CommunityToolkit.App.Wasdk.csproj" (Clean;Build target) (1:7) ->
"V:\Labs-Windows\components\MarqueeText\src\CommunityToolkit.Labs.WinUI.MarqueeText.csproj" (default target) (17:31) ->
V:\Labs-Windows\components\MarqueeText\src\MarqueeText.Properties.cs(102,30): error CS0234: The type or namespace name 'UI' does not exist in the namespace 'Microsoft.Windows' (are you missing an assembly reference?) [V:\Labs-Windows\components\MarqueeText\src\CommunityToolkit.Labs.WinUI.MarqueeText.csproj::TargetFramework=net8.0-windows10.0.22621.0]

If you try to fix the issue with the other suggestion, Microsoft.WinUI.TextDecorations, you get the same CS0234 "type or namespace does not exist in namespace":

"V:\Labs-Windows\tooling\ProjectHeads\AllComponents\wasdk\CommunityToolkit.App.Wasdk.csproj" (Clean;Build target) (1:7) ->
"V:\Labs-Windows\components\MarkdownTextBlock\src\CommunityToolkit.WinUI.Controls.MarkdownTextBlock.csproj" (default target) (2:31) -> (XamlPreCompile target) ->
V:\Labs-Windows\components\MarkdownTextBlock\src\TextElements\MyEmphasisInline.cs(67,33): error CS0234: The type or namespace name 'WinUI' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [V:\Labs-Windows\components\MarkdownTextBlock\src\CommunityToolkit.WinUI.Controls.MarkdownTextBlock.csproj::TargetFramework=net8.0-windows10.0.22621.0]

"V:\Labs-Windows\tooling\ProjectHeads\AllComponents\wasdk\CommunityToolkit.App.Wasdk.csproj" (Clean;Build target) (1:7) ->
 "V:\Labs-Windows\components\MarqueeText\src\CommunityToolkit.Labs.WinUI.MarqueeText.csproj" (default target) (15:31) ->
V:\Labs-Windows\components\MarqueeText\src\MarqueeText.Properties.cs(102,22): error CS0234: The type or namespace name 'WinUI' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [V:\Labs-Windows\components\MarqueeText\src\CommunityToolkit.Labs.WinUI.MarqueeText.csproj::TargetFramework=net8.0-windows10.0.22621.0]

Similar errors if you try to use the type Windows.UI.Text.TextDecorations.

Anybody know what's happening here? Why is it telling me that these types exist, but erroring when I try to use them?

Sergio0694 · 2024-08-07T23:49:32Z

Ah, yeah this is expected. FYI @manodasanW. @Arlodotexe you'll need to wait for the new SDK projections and WASDK preview.

manodasanW · 2024-08-08T01:24:54Z

If this is just WinAppSDK, you can do the below workaround until we have builds with the right fixes.

    <!-- Temporary workaround -->
    <Target Name="CsWinRTRemoveXamlDllReferences" AfterTargets="ResolveTargetingPackAssets;ResolveReferences" BeforeTargets="XamlPreCompile;CoreCompile" Outputs="@(Reference)">
        <ItemGroup>
            <Reference Remove="@(Reference)"
               Condition="'%(Reference.Filename)%(Reference.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />
            <ReferencePathWithRefAssemblies Remove="@(ReferencePathWithRefAssemblies)"
               Condition="'%(ReferencePathWithRefAssemblies.Filename)%(ReferencePathWithRefAssemblies.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />
            <ReferenceCopyLocalPaths Remove="@(ReferenceCopyLocalPaths)"
               Condition="'%(ReferenceCopyLocalPaths.Filename)%(ReferenceCopyLocalPaths.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />
            <ReferencePath Remove="@(ReferencePath)"
               Condition="'%(ReferencePath.Filename)%(ReferencePath.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />
        </ItemGroup>
    </Target>

manodasanW · 2024-08-09T01:10:25Z

If this is just WinAppSDK, you can do the below workaround until we have builds with the right fixes.

    <!-- Temporary workaround -->
    <Target Name="CsWinRTRemoveXamlDllReferences" AfterTargets="ResolveTargetingPackAssets;ResolveReferences" BeforeTargets="XamlPreCompile;CoreCompile" Outputs="@(Reference)">
        <ItemGroup>
            <Reference Remove="@(Reference)"
               Condition="'%(Reference.Filename)%(Reference.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />
            <ReferencePathWithRefAssemblies Remove="@(ReferencePathWithRefAssemblies)"
               Condition="'%(ReferencePathWithRefAssemblies.Filename)%(ReferencePathWithRefAssemblies.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />
            <ReferenceCopyLocalPaths Remove="@(ReferenceCopyLocalPaths)"
               Condition="'%(ReferenceCopyLocalPaths.Filename)%(ReferenceCopyLocalPaths.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />
            <ReferencePath Remove="@(ReferencePath)"
               Condition="'%(ReferencePath.Filename)%(ReferencePath.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />
        </ItemGroup>
    </Target>

Can you also add the below to the target and see if it helps.

            <RuntimePackAsset Remove="@(RuntimePackAsset)"
               Condition="'%(RuntimePackAsset.Filename)%(RuntimePackAsset.Extension)' == 'Microsoft.Windows.UI.Xaml.dll'" />

…comment)

Arlodotexe · 2024-08-14T03:13:32Z

Not getting any errors when building locally, but CI is throwing:

error MSB3030: Could not copy the file "C:\Users\runneradmin\.nuget\packages\microsoft.web.webview2\1.0.2646-prerelease\build\..\\runtimes\win-anycpu\native_uap\Microsoft.Web.WebView2.Core.dll" because it was not found. [D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\src\CommunityToolkit.Labs.WinUI.TransitionHelper.csproj::TargetFramework=net6.0-windows10.0.22621.0]

Directory.Build.props

Sergio0694 · 2024-08-14T03:36:36Z

@Arlodotexe just as a test, try updating WebView2 to 1.0.2730-prerelease that was released today and see if it helps.

…nRT1028 suppression.

Arlodotexe · 2024-08-14T17:37:50Z

@Arlodotexe just as a test, try updating WebView2 to 1.0.2730-prerelease that was released today and see if it helps.

Our reference to WebView2 is transient and doesn't seem to be coming from Microsoft.WindowsAppSDK. It's happening on the wasdk multitarget for each component source project, even ones with no dependencies like Converters and Extensions. Where is this coming from 🤔

Arlodotexe · 2024-08-14T18:42:56Z

I see, the way WebView2 is bundled with the WindowsAppSDK changed as of Preview1, now using a nuget package. The dependency shows on nuget.org when you select 1.6.240807006-preview1 or greater.

Arlodotexe · 2024-08-14T21:20:03Z

Looks like that resolved our issue with WebView 2.

Seeing an issue from before resurface, reproduces locally and in CI:

Error: D:\a\Labs-Windows\Labs-Windows\components\MarkdownTextBlock\src\TextElements\MyEmphasisInline.cs(72,33): error CS0433: The type 'TextDecorations' exists in both 'Microsoft.WinUI, Version=3.0.0.0...' and 'Microsoft.Windows.SDK.NET, Version=10.0.22621.38...

manodasanW · 2024-08-14T21:43:15Z

Looks like that resolved our issue with WebView 2.

Seeing an issue from before resurface, reproduces locally and in CI:
Error: D:\a\Labs-Windows\Labs-Windows\components\MarkdownTextBlock\src\TextElements\MyEmphasisInline.cs(72,33): error CS0433: The type 'TextDecorations' exists in both 'Microsoft.WinUI, Version=3.0.0.0...' and 'Microsoft.Windows.SDK.NET, Version=10.0.22621.38...

See my comment here: CommunityToolkit/Tooling-Windows-Submodule#195 (comment)

…ppSDK 1.6 Preview1

Arlodotexe · 2024-08-22T20:49:53Z

This warning on wasm-linux might be something to fix in a future PR:

Found version-specific or distribution-specific runtime identifier(s): win10-ARM, win10-ARM64, win10-x64, win10-x86. Affected libraries: Rive.RiveSharp. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.

Arlodotexe · 2024-08-22T22:59:37Z

Seems like tests are failing as a result of some issue with RivePlayer.

System.TypeInitializationException: The type initializer for 'RiveSharp.Factory' threw an exception. ---> System.DllNotFoundException: Unable to load DLL 'rive' or one of its dependencies: The specified module could not be found. (0x8007007E)
  Stack Trace:
      at RiveSharp.RiveAPI.Factory_RegisterDelegates(FactoryDelegates delegates)
   at RiveSharp.Factory..cctor()
--- End of inner exception stack trace ---
    at RiveSharp.Scene..ctor()
   at CommunityToolkit.Labs.WinUI.Rive.RivePlayer..ctor() in /_/components/RivePlayer/src/RivePlayer.cs:line 49
   at RivePlayerExperiment.Tests.ExampleRivePlayerTestClass.ComplexAsyncLoadUIExampleWithoutDispatcherTest() in D:\a\Labs-Windows\Labs-Windows\components\RivePlayer\tests\ExampleRivePlayerTestClass.cs:line 121
   at RivePlayerExperiment.Tests.ExampleRivePlayerTestClass.<ComplexAsyncLoadUIExampleWithoutDispatcherTest_ExampleRivePlayerTestClass_Test>b__12_0() in /_/ProjectHeads/AllComponents/Tests.Wasdk/obj/x64/Release/net8.0-windows10.0.22621.0/win-x64/CommunityToolkit.Tooling.TestGen/CommunityToolkit.Tooling.TestGen.UIThreadTestMethodGenerator/ComplexAsyncLoadUIExampleWithoutDispatcherTest_ExampleRivePlayerTestClass.g.cs:line 15

Track #567

Sergio0694

LGTM, minus those leftover ifdefs with the same code.

…comment)

Arlodotexe added 4 commits August 7, 2024 18:22

Fix ambiguous references to TitleBar

0c560df

Cleanup for ambiguous reference fix

729f407

Fixed CsWinRT1028

ce970ba

Update WinAppSDK to 1.6.240701003-experimental2

411ab59

Arlodotexe added 2 commits August 8, 2024 14:14

Fix ambiugous reference

622a1a8

Fully qualify Microsoft.UI.Text.FontWeights

da4c61e

Arlodotexe added a commit to CommunityToolkit/Tooling-Windows-Submodule that referenced this pull request Aug 9, 2024

Add WinAppSDK 1.6 workaround. See CommunityToolkit/Labs-Windows#561 (…

127bdc3

…comment)

Arlodotexe added 3 commits August 9, 2024 13:51

Update tooling

c70f95d

Update tooling

a51b16d

Add CsWinRT1028 suppression

e889572

Sergio0694 reviewed Aug 14, 2024

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

Arlodotexe mentioned this pull request Aug 14, 2024

Updated to WinAppSdk 1.6, fixed AoT annotations CommunityToolkit/Windows#457

Merged

Arlodotexe added 2 commits August 14, 2024 11:49

Update Microsoft.WindowsAppSDK to 1.6.240807006-preview1, remove CsWi…

27e81e4

…nRT1028 suppression.

Fixed CsWinRT1028 errors

2fe3801

Update WindowsSdkPackageVersion for Wasdk 1.6 preview1

ecaa8dc

Arlodotexe added 2 commits August 14, 2024 14:36

Update transient WebView2 reference to 1.0.2730-prerelease

8452130

Fully qualify TextDecorations on WinUI 3

cb8bbaa

Arlodotexe added 2 commits August 15, 2024 12:05

Revert WindowsSdkPackageVersion to 10.0.22621.37-preview for WindowsA…

e925ed1

…ppSDK 1.6 Preview1

Update tooling with latest CsWinRT1028 fixes

25aded9

Arlodotexe mentioned this pull request Aug 16, 2024

Update to WinAppSdk 1.6, enable AoT on gallery head CommunityToolkit/Tooling-Windows-Submodule#195

Merged

Update tooling pointer

7955365

Arlodotexe mentioned this pull request Aug 16, 2024

Update to Microsoft.WindowsAppSDK 1.6, enable AoT. CommunityToolkit/Tooling-Windows-Submodule#205

Open

Arlodotexe added 3 commits August 16, 2024 18:00

Update tooling pointer

2d37d77

Remove clean task to resolve CommunityToolkit/Windows#457 (comment)

d0ac9b4

Merge branch 'main' into wasdk/1.6

4d4d676

Arlodotexe mentioned this pull request Aug 23, 2024

RivePlayer is not AoT compatible (Windows App SDK 1.6) #567

Open

Disabled RivePlayer tests on WindowsAppSDK.

88dabef

Track #567

Sergio0694 approved these changes Aug 23, 2024

View reviewed changes

Arlodotexe added a commit to CommunityToolkit/Tooling-Windows-Submodule that referenced this pull request Aug 23, 2024

Add WinAppSDK 1.6 workaround. See CommunityToolkit/Labs-Windows#561 (…

e808f5b

…comment)

Update tooling to latest main

d346d3a

Arlodotexe enabled auto-merge August 23, 2024 19:33

Arlodotexe merged commit 0d89e01 into main Aug 23, 2024
20 of 21 checks passed

Arlodotexe deleted the wasdk/1.6 branch August 23, 2024 20:18

Arlodotexe mentioned this pull request Sep 9, 2024

Update Microsoft.WindowsAppSDK to 1.6 stable CommunityToolkit/Tooling-Windows-Submodule#209

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated to WinAppSdk 1.6, fixed AoT annotations #561

Updated to WinAppSdk 1.6, fixed AoT annotations #561

Arlodotexe commented Aug 7, 2024

Arlodotexe commented Aug 7, 2024

Sergio0694 commented Aug 7, 2024

manodasanW commented Aug 8, 2024

manodasanW commented Aug 9, 2024

Arlodotexe commented Aug 14, 2024

Sergio0694 commented Aug 14, 2024

Arlodotexe commented Aug 14, 2024

Arlodotexe commented Aug 14, 2024

Arlodotexe commented Aug 14, 2024

manodasanW commented Aug 14, 2024

Arlodotexe commented Aug 22, 2024 •

edited

Loading

Arlodotexe commented Aug 22, 2024 •

edited

Loading

Sergio0694 left a comment

Updated to WinAppSdk 1.6, fixed AoT annotations #561

Updated to WinAppSdk 1.6, fixed AoT annotations #561

Conversation

Arlodotexe commented Aug 7, 2024

Arlodotexe commented Aug 7, 2024

Sergio0694 commented Aug 7, 2024

manodasanW commented Aug 8, 2024

manodasanW commented Aug 9, 2024

Arlodotexe commented Aug 14, 2024

Sergio0694 commented Aug 14, 2024

Arlodotexe commented Aug 14, 2024

Arlodotexe commented Aug 14, 2024

Arlodotexe commented Aug 14, 2024

manodasanW commented Aug 14, 2024

Arlodotexe commented Aug 22, 2024 • edited Loading

Arlodotexe commented Aug 22, 2024 • edited Loading

Sergio0694 left a comment

Choose a reason for hiding this comment

Arlodotexe commented Aug 22, 2024 •

edited

Loading

Arlodotexe commented Aug 22, 2024 •

edited

Loading