-
Notifications
You must be signed in to change notification settings - Fork 440
Full screen events #2041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ne0rrmatrix
wants to merge
94
commits into
CommunityToolkit:main
Choose a base branch
from
ne0rrmatrix:FullScreenEvents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Full screen events #2041
Changes from 56 commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
bba92d1
Add full screen state management for media elements
ne0rrmatrix 2aaa53e
Merge Main into FullScreenEvents
ne0rrmatrix 6db6b06
fix merge bug
ne0rrmatrix 17601c3
Enhance fullscreen event handling
ne0rrmatrix 7669d0a
fix fullscreen event handling macios
ne0rrmatrix 38c5834
Update comment for OnWindowsChanged event
ne0rrmatrix 2783077
Merge branch 'CommunityToolkit:main' into FullScreenEvents
ne0rrmatrix 47b6434
Merge branch 'CommunityToolkit:main' into FullScreenEvents
ne0rrmatrix 5185222
Merge Main into FullScreenEvents
ne0rrmatrix 8198c94
fix merge errror
ne0rrmatrix 6d34192
Fix another merge error
ne0rrmatrix d7c12eb
Merge branch 'FullScreenEvents' of https://github.com/ne0rrmatrix/Mau…
ne0rrmatrix afa937f
Merge branch 'CommunityToolkit:main' into FullScreenEvents
ne0rrmatrix 6c8b106
Refactor full-screen event handling
ne0rrmatrix 697950d
Merge branch 'FullScreenEvents' of https://github.com/ne0rrmatrix/Mau…
ne0rrmatrix 5706688
fix spacing issue
ne0rrmatrix 201e54e
Refactor full-screen state handling
ne0rrmatrix 4a12906
Centralize FullScreenEvents subscription
ne0rrmatrix 3425c25
fix cosmetic issues
ne0rrmatrix 7f75702
More Cosmetic Fixes
ne0rrmatrix 8bfed07
Refactor full screen event handling
ne0rrmatrix 58ffa61
Increase accessibility and refine directives
ne0rrmatrix 1e65556
Refine visibility and structure of records
ne0rrmatrix 4abb02c
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 63bf581
Merge branch 'main' into FullScreenEvents
ne0rrmatrix b43ccfa
Merge branch 'main' into FullScreenEvents
TheCodeTraveler f1c1ae6
Merge branch 'main' into FullScreenEvents
ne0rrmatrix f9a516c
Merge branch 'main' into FullScreenEvents
ne0rrmatrix fa8e9fb
Merge branch 'main' into FullScreenEvents
ne0rrmatrix fddb7f6
Merge branch 'main' into FullScreenEvents
ne0rrmatrix aa09b29
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 2f6c67e
Merge branch 'main' into FullScreenEvents
ne0rrmatrix de01200
Merge branch 'main' into FullScreenEvents
ne0rrmatrix ba378b9
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 69714db
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 6dba9bb
Merge branch 'main' into FullScreenEvents
ne0rrmatrix c3322fa
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 72bc9da
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 279cd7f
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 2bb21dd
Merge branch 'main' into FullScreenEvents
ne0rrmatrix ebe0d60
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 142544c
Merge branch 'CommunityToolkit:main' into FullScreenEvents
ne0rrmatrix 112e7e5
Merge branch 'CommunityToolkit:main' into FullScreenEvents
ne0rrmatrix 5ffabb7
Merge branch 'main' into FullScreenEvents
ne0rrmatrix ee8868a
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 1684f86
Merge branch 'main' into FullScreenEvents
ne0rrmatrix d1bebfd
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 1590fe1
Merge branch 'main' into FullScreenEvents
ne0rrmatrix a0e47d7
Merge branch 'main' into FullScreenEvents
ne0rrmatrix f585895
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 2a6f156
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 2b35903
Merge branch 'main' into FullScreenEvents
ne0rrmatrix b72c39e
Merge branch 'main' into FullScreenEvents
ne0rrmatrix a5028d2
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 9ce744b
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 6f94766
Merge branch 'main' into FullScreenEvents
ne0rrmatrix c841e3c
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 33f44ba
Merge branch 'main' into FullScreenEvents
TheCodeTraveler dfa7af1
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 8bdb8a9
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 692c286
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 59e7e1c
Merge branch 'main' into FullScreenEvents
ne0rrmatrix b26bb60
Fix Merge Confilicts
ne0rrmatrix 94436e2
fix merge error
ne0rrmatrix 77878ed
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 4367ea1
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 8687ea0
Merge branch 'main' into FullScreenEvents
ne0rrmatrix f82392d
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 93dbdc2
Merge branch 'main' into FullScreenEvents
ne0rrmatrix bf5b70e
Rename OnWindowsChanged to OnFullScreenStateChanged
ne0rrmatrix 4867fa6
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 05be19c
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 06b2a1e
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 621840b
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 44c0afa
Merge branch 'main' into FullScreenEvents
ne0rrmatrix e8adc95
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 19f9526
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 45580dd
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 9a38eb3
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 8388539
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 6d98bdf
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 42b91a2
Refactor full-screen event handling
ne0rrmatrix e513a81
Merge branch 'main' into FullScreenEvents
ne0rrmatrix be5d58c
Refactor FullScreenEvents to use instance methods
ne0rrmatrix 72a8769
Merge branch 'FullScreenEvents' of https://github.com/ne0rrmatrix/Mau…
ne0rrmatrix fe1d20d
Merge branch 'main' into FullScreenEvents
TheCodeTraveler 2ae03fb
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 637dfbc
Fix Merge Conflict
ne0rrmatrix f7beb35
Merge branch 'main' into FullScreenEvents
ne0rrmatrix f2d2d04
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 93a534e
Merge branch 'main' into FullScreenEvents
ne0rrmatrix d63101f
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 84774e8
Merge branch 'main' into FullScreenEvents
ne0rrmatrix 779d8d9
Merge branch 'main' into FullScreenEvents
ne0rrmatrix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
src/CommunityToolkit.Maui.MediaElement/Primitives/FullScreenStateChangedEventArgs.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
namespace CommunityToolkit.Maui.Primitives; | ||
|
||
/// <summary> | ||
/// Event data for when the full screen state of the media element has changed. | ||
/// </summary> | ||
public sealed class FullScreenStateChangedEventArgs | ||
{ | ||
/// <summary> | ||
/// Initializes a new instance of the <see cref="FullScreenStateChangedEventArgs"/> class. | ||
/// </summary> | ||
/// <param name="previousState"></param> | ||
/// <param name="newState"></param> | ||
public FullScreenStateChangedEventArgs(MediaElementScreenState previousState, MediaElementScreenState newState) | ||
{ | ||
PreviousState = previousState; | ||
NewState = newState; | ||
} | ||
|
||
/// <summary> | ||
/// Gets the previous state that the <see cref="Core.IMediaElement"/> instance is transitioning from. | ||
/// </summary> | ||
public MediaElementScreenState PreviousState { get; } | ||
|
||
/// <summary> | ||
/// Gets the new state that the <see cref="Core.IMediaElement"/> instance is transitioning to. | ||
/// </summary> | ||
public MediaElementScreenState NewState { get; } | ||
} |
17 changes: 17 additions & 0 deletions
17
src/CommunityToolkit.Maui.MediaElement/Primitives/MediaElementFullScreenState.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
namespace CommunityToolkit.Maui.Primitives; | ||
|
||
/// <summary> | ||
/// | ||
/// </summary> | ||
public enum MediaElementScreenState | ||
{ | ||
/// <summary> | ||
/// Full screen. | ||
/// </summary> | ||
FullScreen, | ||
|
||
/// <summary> | ||
/// The default state. | ||
/// </summary> | ||
Default, | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.