-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows Media Element in MultiWindow Mode on exit Crash #2259
base: main
Are you sure you want to change the base?
Fix Windows Media Element in MultiWindow Mode on exit Crash #2259
Conversation
Added a static `NumberOfWindows` property to the `Options` class to track the number of windows. Updated `SetShouldEnableSnackbarOnWindows` to increment/decrement `NumberOfWindows` on window creation/closure. Conditional registration/unregistration of `AppNotificationManager` for snackbar notifications based on `NumberOfWindows` count.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changed fixed #2279
Hoping it will be released soon
Can some please resolve this merge conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
I am new to this process, and don't understand who needs to do what to get this done, but I would appreciate any help to get the mission accomplished. @brminnick @ne0rrmatrix @pictos @softlion |
Description of Change
Track window count and manage snackbar notifications
Added a static
NumberOfWindows
property to theOptions
class to track the number of windows. UpdatedSetShouldEnableSnackbarOnWindows
to increment/decrementNumberOfWindows
on window creation/closure. Conditional registration/unregistration ofAppNotificationManager
for snackbar notifications based onNumberOfWindows
count.Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information
This PR uses a simple counter to track the number of windows that exist and only when one is remaining will it unregister Snackview