Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XUnit V3 #2486

Merged
merged 15 commits into from
Feb 3, 2025
Merged

XUnit V3 #2486

merged 15 commits into from
Feb 3, 2025

Conversation

VladislavAntonyuk
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk commented Feb 2, 2025

@Copilot Copilot bot review requested due to automatic review settings February 2, 2025 20:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • samples/CommunityToolkit.Maui.Sample.sln: Language not supported
  • src/CommunityToolkit.Maui.Analyzers.UnitTests/CommunityToolkit.Maui.Analyzers.UnitTests.csproj: Language not supported
  • src/CommunityToolkit.Maui.Analyzers.UnitTests/xunit.runner.json: Language not supported
  • src/CommunityToolkit.Maui.UnitTests/CommunityToolkit.Maui.UnitTests.csproj: Language not supported
  • src/CommunityToolkit.Maui.UnitTests/xunit.runner.json: Language not supported
Updated `InitializeServicesAndSetMockApplication` to use
`serviceProvider` for setting the Maui context. Removed
unnecessary `using` directive and `AnimationManager`
property from `HandlersContextStub`, indicating a
refactor of animation management functionality.
Copy link
Contributor

@ne0rrmatrix ne0rrmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! I am currently on iteration 28 with zero errors! But the one issue still persisting in tests is line 63 public async Task InvalidValue_InvalidStyle() in ValidationBehaviorTests.cs is failing randomly. My tests have that commented out. If you can figure out that one test failing this PR will be even better. I am waiting for the local run to complete a 1000 round test. I am going to wait to see how it runs but i think this PR is very close to being ready. It is 100 percent better than current tests now. But that one test is still failing randomly.

@VladislavAntonyuk
Copy link
Collaborator Author

VladislavAntonyuk commented Feb 3, 2025

@ne0rrmatrix do you see the test (InvalidValue_InvalidStyle) fails randomly on your local env?
The last 2 builds on pipeline are stable without failed tests.
I updated the test to use custom comparison.

Copy link
Contributor

@ne0rrmatrix ne0rrmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I am happy with the results of this change. I see a 5X increase in average reliability after extensive testing in local environment.

@VladislavAntonyuk VladislavAntonyuk merged commit fa4004d into main Feb 3, 2025
10 checks passed
@VladislavAntonyuk VladislavAntonyuk deleted the xunit-v3 branch February 3, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants