Skip to content

Fix Memory Leak for Media Element in Windows #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ne0rrmatrix wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix Memory Leak for Media Element in Windows #3115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a1bb21
Remove duplicated event and move behavior to the same event in anothe…
ne0rrmatrix Feb 23, 2026
9933ebe
Merge branch 'main' into FixMediaElementDanglingEventHandler
ne0rrmatrix Feb 27, 2026
db9c212
Merge branch 'main' into FixMediaElementDanglingEventHandler
ne0rrmatrix Mar 8, 2026
2731dcf
Merge branch 'main' into FixMediaElementDanglingEventHandler
ne0rrmatrix Mar 11, 2026
eea2d07
Merge branch 'main' into FixMediaElementDanglingEventHandler
ne0rrmatrix Mar 11, 2026
d4b9322
Merge branch 'main' into FixMediaElementDanglingEventHandler
ne0rrmatrix Mar 18, 2026
eb25595
Merge branch 'main' into FixMediaElementDanglingEventHandler
ne0rrmatrix Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/CommunityToolkit.Maui.MediaElement/Primitives/CustomTransportControls.windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ sealed partial class CustomTransportControls : MediaTransportControls
{
public event EventHandler<EventArgs>? OnTemplateLoaded;
public AppBarButton FullScreenButton = new();
bool isFullScreen = false;

public CustomTransportControls()
{
Expand All @@ -22,21 +21,6 @@ protected override void OnApplyTemplate()
FullScreenButton = appBarButton;
FullScreenButton.Visibility = Microsoft.UI.Xaml.Visibility.Visible;
OnTemplateLoaded?.Invoke(this, EventArgs.Empty);
FullScreenButton.Click += FullScreenButton_Click;
}
}

void FullScreenButton_Click(object sender, RoutedEventArgs e)
{
if (isFullScreen)
{
FullScreenButton.Icon = new FontIcon { Glyph = "\uE740" };
isFullScreen = false;
}
else
{
FullScreenButton.Icon = new SymbolIcon(Symbol.BackToWindow);
isFullScreen = true;
}
}
}
2 changes: 2 additions & 0 deletions src/CommunityToolkit.Maui.MediaElement/Views/MauiMediaElement.windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ void OnFullScreenButtonClick(object sender, RoutedEventArgs e)
var parent = mediaPlayerElement.Parent as FrameworkElement;
mediaPlayerElement.Width = parent?.Width ?? mediaPlayerElement.Width;
mediaPlayerElement.Height = parent?.Height ?? mediaPlayerElement.Height;
customTransportControls?.FullScreenButton.Icon = new FontIcon { Glyph = "\uE740" };
}
else
{
Expand All @@ -221,6 +222,7 @@ void OnFullScreenButtonClick(object sender, RoutedEventArgs e)
{
popup.IsOpen = true;
}
customTransportControls?.FullScreenButton.Icon = new SymbolIcon(Symbol.BackToWindow);
}
}
}
Loading