Add SoftInputKeyboardPopup and integrate keyboard handling for popups#3117
Add SoftInputKeyboardPopup and integrate keyboard handling for popups#3117FabriBertani wants to merge 3 commits intoCommunityToolkit:mainfrom
Conversation
pictos
left a comment
pictos
left a comment
There was a problem hiding this comment.
Just a small adjustments, also can you remove the comments on code?
| using CommunityToolkit.Maui.Extensions; | ||
| #if ANDROID | ||
| using Microsoft.Maui.Controls.PlatformConfiguration.AndroidSpecific; | ||
| #elif IOS && !NET10_0_OR_GREATER |
There was a problem hiding this comment.
you can have back compatibility, this version will not install on NET 9 anyway. On toolkit we only support the current .NET version
| { | ||
| Opened?.Invoke(this, EventArgs.Empty); | ||
|
|
||
| #if ANDROID |
There was a problem hiding this comment.
instead of using #ifs can you create a platform file (Popup.android.cs) and put the code there? You can define partial void methods to implement and called from the shared layer.
| On<iOS>().SetModalPresentationStyle(UIModalPresentationStyle.OverFullScreen); | ||
| NavigationPage.SetHasNavigationBar(this, false); | ||
|
|
||
| #if NET10_0_OR_GREATER |
Just the comments or the summaries as well? |
just the comments, the summaries are fine |
|
done |
…keyboard handling
pictos
left a comment
pictos
left a comment
There was a problem hiding this comment.
Thanks for you contribution!
LGTM
2 participants
Description of Change
Fix added for the issue related to the OS keyboard overlapping the popup content on Android and iOS, with backward compatibility to .NET9
This fix behaves on both platforms the same as Android adjust resize input option, by pushing the popup content above the keyboard.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information