Skip to content

Fix CameraView StopCameraPreviewCommand #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhitaop wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix CameraView StopCameraPreviewCommand #3158

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
079f2bb
Fix StopCameraPreviewCommand
zhitaop Mar 17, 2026
308809d
Merge branch 'main' into fix/stop-camera-preview-command
zhitaop Mar 19, 2026
86d7a38
Merge branch 'main' into fix/stop-camera-preview-command
zhitaop Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/CommunityToolkit.Maui.Camera/Views/CameraView.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public partial class CameraView : View, ICameraView, IDisposable
/// Bindable property for the <see cref="StopCameraPreviewCommand"/> property.
/// </summary>
public static readonly BindableProperty StopCameraPreviewCommandProperty =
BindableProperty.CreateReadOnly(nameof(StopCameraPreviewCommand), typeof(Command<CancellationToken>), typeof(CameraView), null, BindingMode.OneWayToSource, defaultValueCreator: CreateStopCameraPreviewCommand).BindableProperty;
BindableProperty.CreateReadOnly(nameof(StopCameraPreviewCommand), typeof(ICommand), typeof(CameraView), null, BindingMode.OneWayToSource, defaultValueCreator: CreateStopCameraPreviewCommand).BindableProperty;

/// <summary>
/// Bindable property for the <see cref="StartVideoRecordingCommand"/> property.
Expand Down Expand Up @@ -137,12 +137,9 @@ public event EventHandler<MediaCapturedEventArgs> MediaCaptured
public Command<CancellationToken> StartCameraPreviewCommand => (Command<CancellationToken>)GetValue(StartCameraPreviewCommandProperty);

/// <summary>
/// Gets the <see cref="Command{CancellationToken}"/> that stops the camera preview.
/// Gets the <see cref="ICommand"/> that stops the camera preview.
/// </summary>
/// <remarks>
/// <see cref="StopCameraPreviewCommand"/> has a <see cref="Type"/> of Command&lt;CancellationToken&gt; which requires a <see cref="CancellationToken"/> as a CommandParameter. See <see cref="Command{CancellationToken}"/> and <see cref="System.Windows.Input.ICommand.Execute(object)"/> for more information on passing a <see cref="CancellationToken"/> into <see cref="Command{T}"/> as a CommandParameter
/// </remarks>
public Command<CancellationToken> StopCameraPreviewCommand => (Command<CancellationToken>)GetValue(StopCameraPreviewCommandProperty);
public ICommand StopCameraPreviewCommand => (ICommand)GetValue(StopCameraPreviewCommandProperty);
Comment on lines +140 to +142

/// <summary>
/// Gets the <see cref="Command{Stream}"/> that starts video recording.
Expand Down
Loading