Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery design improvements #88

Merged
merged 10 commits into from
Jul 19, 2023
Merged

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Jun 22, 2023

  • WASDK: window title + Mica 🎉
  • WASM: searchbox now works due to a recent Uno upgrade.
  • A new design for the titlebar: this brings the searchbox + menu button to the titlebar area, saving us precious vertical space - and inline with W11 design guidelines. Addressing: [Gallery] Move searchbox and menu button to titlebar #85

image

@Arlodotexe @michael-hawker the TitleBar code is a local copy of the code that lives in Labs: CommunityToolkit/Labs-Windows#459. I'd recommend to flag any non-blocking issues/improvements/feedback there vs. here, as that component would eventually replace this.

@ghost1372
Copy link

ghost1372 commented Jul 4, 2023

Hi @niels9001
TitleBar is working fine, but How to make our search control look like MS store?
TitleBar Height is Same, AutoSuggestBox Height also is same, but MS Store AutoSuggestBox has a margin and it is vertically in the center, I used margin, but it got messed up like the picture below. I know that the desired result can be achieved by changing the height of the title bar, but as you can see in the picture, the height of the store title bar and our app is same So how do we achieve it?.

Update:
VerticalAlignment="Center" is not working too.

xxx

@niels9001
Copy link
Collaborator Author

Hi @niels9001 TitleBar is working fine, but How to make our search control look like MS store? TitleBar Height is Same, AutoSuggestBox Height also is same, but MS Store AutoSuggestBox has a margin and it is vertically in the center, I used margin, but it got messed up like the picture below. I know that the desired result can be achieved by changing the height of the title bar, but as you can see in the picture, the height of the store title bar and our app is same So how do we achieve it?.

Update: VerticalAlignment="Center" is not working too.

xxx

Yeah, needs some more work.. this is a nice test case to see if this is easy to replicate.

I have moved the code to a new Labs experiment so we can further iterate and test there with samples included. Let's move this discussion there :-)!

CommunityToolkit/Labs-Windows#459

@niels9001 niels9001 marked this pull request as ready for review July 17, 2023 15:08
@niels9001 niels9001 changed the title Titlebar improvements Gallery design improvements Jul 17, 2023
@michael-hawker
Copy link
Member

@niels9001 we'll want to do the setup I did for the Converters in #99 for this TitleBar package of labs. Then we'll define the property in the Labs root when we update the tooling submodule reference. In Labs it'll use the source, so that you can work on the titlebar and use it in the sample app, and in Windows it'll just grab the latest NuGet package from the feed (assuming we have the Labs feed setup there).

@niels9001
Copy link
Collaborator Author

@michael-hawker since the TitleBar code in this PR is just temporarily (later to be swapped out for the control that is in PR for Labs) this should be good to go if nothing is blocking, right?

This would just be a local control for now (with a different namespace) so we shouldn't run into any issues when developing the one in Labs - once that's finished we probably need to follow what you did for the converters?

@niels9001 niels9001 merged commit 764ecb6 into main Jul 19, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the niels9001/titlebar-improvements branch July 19, 2023 18:48
@michael-hawker
Copy link
Member

@niels9001 yeah, should be fine as long as in different namespace. Then once the control is finished, we can swap it out and use the extensions/converters fix the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants