Skip to content

Commit

Permalink
Fixes issues with the build script in detecting dump files to upload …
Browse files Browse the repository at this point in the history
…and analyze

dorny/paths-filter only works on detecting changes to git files not untracked files
  • Loading branch information
michael-hawker committed Aug 14, 2023
1 parent 10adbf7 commit f70cbd3
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,26 +182,22 @@ jobs:

# https://github.com/dorny/paths-filter#custom-processing-of-changed-files
- name: Detect If any Dump Files
uses: dorny/paths-filter@v2.11.1
id: filter
with:
list-files: shell
filters: |
dump:
- added: '${{ github.workspace }}/CrashDumps/*.dmp'
id: detect-dump
run: |
echo "DUMP_FILE=$(ls -1 ${{ github.workspace }}/CrashDumps/*.dmp)" >> "$GITHUB_OUTPUT"
- name: Artifact - WER crash dumps
uses: actions/upload-artifact@v3
if: ${{ steps.filter.outputs.dump == 'true' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
if: ${{ steps.detect-dump.outputs.DUMP_FILE != '' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
with:
name: CrashDumps-${{ matrix.platform }}
path: '${{ github.workspace }}/CrashDumps'

- name: Analyze Dump
if: ${{ steps.filter.outputs.dump == 'true' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
if: ${{ steps.detect-dump.outputs.DUMP_FILE != '' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
run: |
dotnet tool install --global dotnet-dump
dotnet-dump analyze ${{ steps.filter.outputs.dump_files }} -c "clrstack" -c "pe -lines" -c "exit"
dotnet-dump analyze ${{ steps.detect-dump.outputs.DUMP_FILE }} -c "clrstack" -c "pe -lines" -c "exit"
wasm-linux:
runs-on: ubuntu-latest
Expand Down

0 comments on commit f70cbd3

Please sign in to comment.