Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.WindowsAppSDK to 1.6-preview2 #492

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Aug 26, 2024

This PR updates our tooling to use Microsoft.WindowsAppSDK 1.6-preview2 and removes prior workarounds only needed for preview1.

Prerequisite PR: CommunityToolkit/Tooling-Windows-Submodule#208

@michael-hawker
Copy link
Member

@Arlodotexe is there anything that's blocking us from merging the preview2 updates?

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Sep 4, 2024

@Arlodotexe is there anything that's blocking us from merging the preview2 updates?

Nothing blocking us from merging, CI seems to be all green and it's working well deployed locally.

Was hoping to use this PR to enable and work through the additional CsWinRTAotWarningLevel analyzer warnings suggested by Sergio here, in the last PR.

@Arlodotexe
Copy link
Member Author

@Arlodotexe is there anything that's blocking us from merging the preview2 updates?

Nothing blocking us from merging, CI seems to be all green and it's working well deployed locally.

Was hoping to use this PR to enable and work through the additional CsWinRTAotWarningLevel analyzer warnings suggested by Sergio here, in the last PR.

With 1.6 stable out now, we'll do this in a separate PR to keep things moving.

@michael-hawker
Copy link
Member

Approved to unblock you once the tooling submodule is updated

@Arlodotexe Arlodotexe enabled auto-merge (rebase) September 6, 2024 20:54
auto-merge was automatically disabled September 6, 2024 23:44

Rebase failed

@Arlodotexe Arlodotexe merged commit 3e6703b into main Sep 9, 2024
24 checks passed
@Arlodotexe Arlodotexe deleted the wasdk/1.6 branch September 9, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants