Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pointer for testing WebView2Loader removal #521

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

michael-hawker
Copy link
Member

Tries to remove extraneous WebView2Loader that was included in WASDK 1.6. If this works we can report back to platform team for proper fix.

Required PR: CommunityToolkit/Tooling-Windows-Submodule#216

Info in CommunityToolkit/Tooling-Windows-Submodule#215

@michael-hawker
Copy link
Member Author

Nope, this did not seemingly resolve the issue:

image

@Arlodotexe you want to confirm I put the flag in a good place in the tooling PR?

Btw, UWP packages look good now that we have the #490 / #500 regression fixed:

image

@Arlodotexe
Copy link
Member

Arlodotexe commented Sep 24, 2024

@Arlodotexe you want to confirm I put the flag in a good place in the tooling PR?

Looks like it was put in a good place. If this is the correct property, I'm not sure why it'd be failing 🤔
Would be good to dig through the binlog to see if the property was blocked by the condition or if it just didn't work.

@Arlodotexe
Copy link
Member

Arlodotexe commented Sep 25, 2024

Let's try Sergio's comment here, just need to bump the webview2 version in the submodule.

@Arlodotexe
Copy link
Member

@michael-hawker I've managed to fix the issue. It took a combination of updating WebView2 (as per @Sergio0694's suggestion) and removing both conditions around WebView2NeverCopyLoaderDllToOutputDirectory. Leaving either condition would result in broken packages again, but with both removed and webview2 updated:

image

This seems to have also resolved the issue with the extra net8.0-windows10.0.22621.0 TFM being included alongside net8.0-windows10.0.22621.

@michael-hawker
Copy link
Member Author

Looks good here! 🎉

image

Though now we have the hard/dependency inclusion of WebView2:

image

@Sergio0694
Copy link
Member

"Though now we have the hard/dependency inclusion of WebView2"

Mark that as PrivateAssets="all" for now to fix that. It's transitive anyway through WinAppSDK.

@michael-hawker
Copy link
Member Author

"Though now we have the hard/dependency inclusion of WebView2"

Mark that as PrivateAssets="all" for now to fix that. It's transitive anyway through WinAppSDK.

FYI @Arlodotexe for CommunityToolkit/Tooling-Windows-Submodule#216

@Arlodotexe Arlodotexe marked this pull request as ready for review September 26, 2024 16:27
@Arlodotexe Arlodotexe enabled auto-merge (rebase) September 27, 2024 17:06
@Arlodotexe Arlodotexe merged commit 5fd59df into main Oct 3, 2024
24 checks passed
@Arlodotexe Arlodotexe deleted the llama/webview2loader branch October 3, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants