Skip to content

Lower the opacity of a BitmapIcon when card is Disabled #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 3, 2025
Merged

Lower the opacity of a BitmapIcon when card is Disabled #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fbee329
Lower the opacity of a BitmapIcon when card is Disabled
niels9001 Sep 25, 2025
243f478
Using VisualStates vs codebehind
niels9001 Sep 28, 2025
a30fac4
Fixes
niels9001 Sep 29, 2025
5311dec
More tweaks
niels9001 Sep 29, 2025
873d529
Merge branch 'main' into niels9001/disabled-image-icon
niels9001 Sep 29, 2025
5f2cfd2
Update SettingsCard.cs
niels9001 Oct 2, 2025
17ad7ab
Update SettingsCard.cs
niels9001 Oct 2, 2025
24fd34c
Merge branch 'main' into niels9001/disabled-image-icon
Arlodotexe Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions components/SettingsControls/src/SettingsCard/SettingsCard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.ComponentModel.Design;

namespace CommunityToolkit.WinUI.Controls;

/// <summary>
Expand All @@ -21,6 +19,9 @@ namespace CommunityToolkit.WinUI.Controls;
[TemplateVisualState(Name = PressedState, GroupName = CommonStates)]
[TemplateVisualState(Name = DisabledState, GroupName = CommonStates)]

[TemplateVisualState(Name = BitmapHeaderIconEnabledState, GroupName = BitmapHeaderIconStates)]
[TemplateVisualState(Name = BitmapHeaderIconDisabledState, GroupName = BitmapHeaderIconStates)]

[TemplateVisualState(Name = RightState, GroupName = ContentAlignmentStates)]
[TemplateVisualState(Name = RightWrappedState, GroupName = ContentAlignmentStates)]
[TemplateVisualState(Name = RightWrappedNoIconState, GroupName = ContentAlignmentStates)]
Expand All @@ -38,6 +39,10 @@ public partial class SettingsCard : ButtonBase
internal const string PressedState = "Pressed";
internal const string DisabledState = "Disabled";

internal const string BitmapHeaderIconStates = "BitmapHeaderIconStates";
internal const string BitmapHeaderIconEnabledState = "BitmapHeaderIconEnabled";
internal const string BitmapHeaderIconDisabledState = "BitmapHeaderIconDisabled";

internal const string ContentAlignmentStates = "ContentAlignmentStates";
internal const string RightState = "Right";
internal const string RightWrappedState = "RightWrapped";
Expand Down Expand Up @@ -76,7 +81,7 @@ protected override void OnApplyTemplate()
CheckInitialVisualState();
SetAccessibleContentName();
RegisterPropertyChangedCallback(ContentProperty, OnContentChanged);
IsEnabledChanged += OnIsEnabledChanged;
IsEnabledChanged += OnIsEnabledChanged;
}

private void CheckInitialVisualState()
Expand All @@ -89,6 +94,8 @@ private void CheckInitialVisualState()
CheckVerticalSpacingState(contentAlignmentStatesGroup.CurrentState);
contentAlignmentStatesGroup.CurrentStateChanged += this.ContentAlignmentStates_Changed;
}

CheckHeaderIconState();
}

// We automatically set the AutomationProperties.Name of the Content if not configured.
Expand Down Expand Up @@ -183,7 +190,6 @@ private void Control_PointerCanceled(object sender, PointerRoutedEventArgs e)
/// </summary>
protected override void OnPointerPressed(PointerRoutedEventArgs e)
{
// e.Handled = true;
if (IsClickEnabled)
{
base.OnPointerPressed(e);
Expand Down Expand Up @@ -228,6 +234,18 @@ private void OnIsClickEnabledChanged()
private void OnIsEnabledChanged(object sender, DependencyPropertyChangedEventArgs e)
{
VisualStateManager.GoToState(this, IsEnabled ? NormalState : DisabledState, true);

CheckHeaderIconState();
}

private void CheckHeaderIconState()
{
// The Disabled visual state will only set the right Foreground brush, but for images we need to lower the opacity so it looks disabled.

if (HeaderIcon is BitmapIcon)
{
VisualStateManager.GoToState(this, IsEnabled ? BitmapHeaderIconEnabledState : BitmapHeaderIconDisabledState, true);
}
}

private void OnActionIconChanged()
Expand All @@ -240,7 +258,7 @@ private void OnActionIconChanged()
}
else
{
actionIconPresenter.Visibility =Visibility.Collapsed;
actionIconPresenter.Visibility = Visibility.Collapsed;
}
}
}
Expand Down
11 changes: 11 additions & 0 deletions components/SettingsControls/src/SettingsCard/SettingsCard.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
<x:Double x:Key="SettingsCardVerticalHeaderContentSpacing">8</x:Double>
<x:Double x:Key="SettingsCardWrapThreshold">476</x:Double>
<x:Double x:Key="SettingsCardWrapNoIconThreshold">286</x:Double>
<x:Double x:Key="SettingsCardBitmapIconDisabledOpacity">0.4</x:Double>

<Style BasedOn="{StaticResource DefaultSettingsCardStyle}"
TargetType="local:SettingsCard" />
Expand Down Expand Up @@ -294,6 +295,16 @@
</VisualState>
</VisualStateGroup>

<!-- These states are only relevant if a BitmapIcon is used as HeaderIcon or ActionIcon. -->
<VisualStateGroup x:Name="BitmapHeaderIconStates">
<VisualState x:Name="BitmapHeaderIconEnabled" />
<VisualState x:Name="BitmapHeaderIconDisabled">
<VisualState.Setters>
<Setter Target="PART_HeaderIconPresenterHolder.Opacity" Value="{StaticResource SettingsCardBitmapIconDisabledOpacity}" />
</VisualState.Setters>
</VisualState>
</VisualStateGroup>

<VisualStateGroup x:Name="ContentAlignmentStates">
<!-- Default -->
<VisualState x:Name="Right" />
Expand Down
Loading