Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu2404] Only enforce valid profile to avoid apparmor issue #12953

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Only enforce valid profile file instead of recursive enforce

Rationale:

  • Current version of noble apparmor-utils has issue, although it's been fixed, this patch hasn't landed in noble yet. We need to find all the profiles then we can enforce to mitigate this issue

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 31, 2025
Copy link

openshift-ci bot commented Jan 31, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codeclimate bot commented Jan 31, 2025

Code Climate has analyzed commit 02ca445 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@alanmcanonical
Copy link
Contributor Author

Here is the tests result on Ubuntu noble vm :
image

@dodys dodys requested a review from a team February 4, 2025 09:11
@dodys dodys self-assigned this Feb 4, 2025
@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Feb 4, 2025
@dodys dodys added this to the 0.1.76 milestone Feb 4, 2025
@dodys
Copy link
Contributor

dodys commented Feb 4, 2025

@alanmcanonical the tests are failing, could you please take a look?

@alanmcanonical
Copy link
Contributor Author

@alanmcanonical the tests are failing, could you please take a look?

It's due to apparmor applicability in container, the vm tests results as pasted work fine

@vojtapolasek vojtapolasek modified the milestones: 0.1.76, 0.1.77 Feb 4, 2025
Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 607e269 into ComplianceAsCode:master Feb 5, 2025
92 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants