Rule: mount_option_boot_efi_nosuid, remove "uefi" platform #12958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule does not care about /sys/firmware/efi, so we should not use existence of this directory as a guardian. Moreover following the logic of "mount_option" template the rule will check and remediate options only if mount point is active/present in /etc/fstab. That's enough to not interfere with non-UEFI systems.
|
Code Climate has analyzed commit e3667e1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
evgenyz
added
productization-issue
|
/retest |
Mab879
approved these changes
Feb 3, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
The rule does not care about
/sys/firmware/efi, so we should not use existence of this directory as a guardian.Moreover following the logic of
mount_optiontemplate the rule will check and remediate options only if mount point is active/present in/etc/fstab. That's enough to not interfere with non-UEFI systems.Fixes
mount_option_boot_efi_nosuidis notapplicable during OSBuild remediation on an UEFI system #12510.Review Hints:
osbuildenv. in the linked issue.