Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu2404] Fix rule 5.3.3.4.1 #12971

Merged

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • [oval] Check all nullok parameters in common-*
  • [remediation/test] Remove all nullok parameters of pam_unix.so

Rationale:

  • Benchmark requires not only common-password to be checked but /etc/pam.d/common-password,auth,account,session,session-noninteractive}

@alanmcanonical alanmcanonical requested a review from a team as a code owner February 4, 2025 20:23
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 4, 2025
Copy link

openshift-ci bot commented Feb 4, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Feb 4, 2025

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
xccdf_org.ssgproject.content_rule_no_empty_passwords is missing in new data stream.

@dodys dodys self-assigned this Feb 5, 2025
@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Feb 5, 2025
@dodys dodys added this to the 0.1.76 milestone Feb 5, 2025
@dodys
Copy link
Contributor

dodys commented Feb 5, 2025

/packit build

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@dodys dodys merged commit 2eacda7 into ComplianceAsCode:stabilization-v0.1.76 Feb 5, 2025
119 of 135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants