-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 24.04 6.1.4.1 Ensure access to all logfiles has been configured #12991
base: master
Are you sure you want to change the base?
Conversation
Hi @ericeberry. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_file_groupowner_var_log_messages'.
--- xccdf_org.ssgproject.content_rule_file_groupowner_var_log_messages
+++ xccdf_org.ssgproject.content_rule_file_groupowner_var_log_messages
@@ -3,7 +3,7 @@
Verify Group Who Owns /var/log/messages File
[description]:
-To properly set the group owner of /var/log/messages, run the command: $ sudo chgrp root /var/log/messages
+To properly set the group owner of /var/log/messages, run the command: $ sudo chgrp adm /var/log/messages
[reference]:
CCI-001314
New data stream is missing bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_groupowner_var_log_messages'.
New data stream is missing bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_groupowner_var_log_syslog'.
New data stream is missing bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_messages'.
New content has different text for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog'.
--- xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
+++ xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
@@ -3,7 +3,7 @@
Verify User Who Owns /var/log/syslog File
[description]:
-To properly set the owner of /var/log/syslog, run the command: $ sudo chown syslog /var/log/syslog
+To properly set the owner of /var/log/syslog, run the command: $ sudo chown root /var/log/syslog
[reference]:
CCI-001314
OCIL for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog' differs.
--- ocil:ssg-file_owner_var_log_syslog_ocil:questionnaire:1
+++ ocil:ssg-file_owner_var_log_syslog_ocil:questionnaire:1
@@ -2,6 +2,6 @@
run the command:
$ ls -lL /var/log/syslog
If properly configured, the output should indicate the following owner:
-syslog
- Is it the case that /var/log/syslog does not have an owner of syslog?
+root
+ Is it the case that /var/log/syslog does not have an owner of root?
New data stream is missing bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog'.
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog' differs.
--- xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
+++ xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
@@ -10,10 +10,10 @@
- medium_severity
- no_reboot_needed
-- name: Ensure owner 104 on /var/log/syslog
+- name: Ensure owner 0 on /var/log/syslog
file:
path: /var/log/syslog
- owner: '104'
+ owner: '0'
when: file_exists.stat is defined and file_exists.stat.exists
tags:
- configure_strategy |
...ide/system/permissions/files/permissions_var_log_dir/file_permissions_var_log_wbtmp/rule.yml
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,31 @@ | |||
<def-group> | |||
<definition class="compliance" id="{{{ rule_id }}}" version="1"> | |||
{{{ oval_metadata("Owner of /var/log/secure should be root or syslog.") }}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed that a very similar OVAL repeats many times in this PR. Please create a Jinja macro to prevent code duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the plan. For expediency, the code is duplicated for now.
...x_os/guide/system/permissions/files/permissions_var_log_dir/file_owner_var_log_auth/rule.yml
Outdated
Show resolved
Hide resolved
...uide/system/permissions/files/permissions_var_log_dir/file_owner_var_log_cloud_init/rule.yml
Outdated
Show resolved
Hide resolved
774da99
to
386ef1e
Compare
Code Climate has analyzed commit 9b3bea2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Description:
Rationale: