Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu2404] Fix the pwquality enable rule #12996

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Use pam-auth-update to create tests
  • Add Conflicts: keyword and increase the priority to override the ubuntu default pwquality config

Rationale:

  • On Ubuntu, Using pam-auth-update is more dynamic and less error-prune.

Copy link

openshift-ci bot commented Feb 7, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 7, 2025
Copy link

codeclimate bot commented Feb 7, 2025

Code Climate has analyzed commit 4bf0988 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Feb 7, 2025
@dodys dodys requested a review from a team February 7, 2025 16:12
@dodys dodys added this to the 0.1.77 milestone Feb 7, 2025
@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Feb 7, 2025
@dodys
Copy link
Contributor

dodys commented Feb 10, 2025

/packit build

Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit e2df811 into ComplianceAsCode:master Feb 10, 2025
94 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants