Adjust variables for banner_etc_issue #14343
Conversation
The previously values with `'` would not work.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
Mab879
requested review from
ggbecker,
jan-cerny,
marcusburghardt and
vojtapolasek
as code owners
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
How have you reproduced the linked issue and how have you verified that this PR fixes the issue?
I can't reproduce the issue using Automatus. However, I can see it reproduced using contest, eg. in the daily productization run today.
I have run /per-rule/oscap/from-env contest test in a custom productization pipeline on this PR and the issue still persists.
What I find suspicious in the HTML report from the initial scan is that the test scenario banner_etc_issue_disa_dod_short.pass.sh doesn't seem to modify the /etc/issue file.
|
|
||
| elif remediation_type == "bash": | ||
| pattern = r'\(bash-populate\s*(\S+)\)' | ||
| pattern = r'\(bash-populate\s*([a-zA-Z0-9_]+)\)' |
There was a problem hiding this comment.
Why is this change needed? It doesn't change the generated data stream. Both old and new version of the shared.sh is matched by the old expression.
2 participants
Description:
Review each commit for details.
Rationale:
Fixes #13690
Review Hints:
Run automatus tests for