Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solana-ibc: use named optional accounts #140

Merged
merged 16 commits into from
Dec 20, 2023
Merged

solana-ibc: use named optional accounts #140

merged 16 commits into from
Dec 20, 2023

Conversation

dhruvja
Copy link
Collaborator

@dhruvja dhruvja commented Dec 4, 2023

Closes #104

@dhruvja
Copy link
Collaborator Author

dhruvja commented Dec 4, 2023

Not ready to merge because currently blocked by coral-xyz/anchor#2101 (comment) . So i will keep in draft until i find a solution for it.

@dhruvja dhruvja marked this pull request as draft December 4, 2023 07:30
@dhruvja dhruvja requested a review from mina86 December 4, 2023 07:31
@dhruvja dhruvja marked this pull request as ready for review December 14, 2023 09:07
@dhruvja
Copy link
Collaborator Author

dhruvja commented Dec 14, 2023

I added another method delivery_init_escrow where the accounts ( token mint and escrow ) needed for transfer are initialized incase they are not. It is similar to the implemented mock_init_escrow. This is done so that we dont run out of stack since initializing accounts take quite a lot of stack space.

@dhruvja
Copy link
Collaborator Author

dhruvja commented Dec 14, 2023

@mina86

mina86
mina86 reviewed Dec 14, 2023
View reviewed changes
dhruvja and others added 4 commits December 19, 2023 13:30
@dhruvja @mina86
Update solana/solana-ibc/programs/solana-ibc/src/lib.rs
872b437 
Co-authored-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Dhruv D Jain <dhruv@iamsizzling.com>
@dhruvja
use as_ref
318e95f
@mina86
from_ctx
17a2542
@mina86
small clenaups
a99a753
@mina86 mina86 changed the title added optional accounts solana-ibc: use named optional accounts Dec 19, 2023
@dhruvja @mina86
Update impls.rs
190131d 
Co-authored-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Dhruv D Jain <dhruv@iamsizzling.com>
@dhruvja dhruvja merged commit d56bd32 into master Dec 20, 2023
4 checks passed
@dhruvja dhruvja deleted the optional-accounts branch December 20, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mina86 mina86 mina86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Optional Accounts
2 participants
@dhruvja @mina86