added method to form message using chunks #165
Conversation
| let cloned_msg_chunks: &mut MsgChunks = &mut msg_chunks.clone(); | ||
| let mut store = storage::from_ctx!(ctx, with accounts); | ||
| let mut router = store.clone(); | ||
|
|
||
| let message = ibc::MsgEnvelope::try_from(ibc::Any::from( | ||
| cloned_msg_chunks.clone(), | ||
| )) |
There was a problem hiding this comment.
Why do we clone msg_chunks twice? Why is cloned_msg_chunks an exclusive reference?
There was a problem hiding this comment.
its a reference because i needed msg_chunks as MsgChunks so that i could convert it. But i think we can ignore it as we are doing the deserializing stuff in the form_msg_chunks method itself. So we would just be fetching the MsgEnvelope from the account and hence no conversions would be required in the deliver_chunks method.
| #[account(init_if_needed, payer = sender, seeds = [MSG_CHUNKS], bump, space = 10240)] | ||
| pub msg_chunks: Account<'info, storage::MsgChunks>, |
There was a problem hiding this comment.
Two things.
First of all, do we need this to be a PDA? I was actually wondering if it wouldn’t be better if this was just an account owned by the sender and then they can manage it in any way they want. All we need here is a writeable account.
Second of all, if this is a PDA it must include sender in the seeds. Without that, users will overwrite each others calls.
There was a problem hiding this comment.
yes i was thinking about it too. I was also looking if we could create an account with data outside of smart contract. Couldnt find anything as now. But we dont need PDA, we could use the sender's account too. Once the deliver_chunks is called, we can also close the account so that we can return the rent.
| /// Struct containing message chunks | ||
| /// | ||
| /// The struct consists of chunks of message data having the first 4 bytes | ||
| /// indicating the total size of the message | ||
| #[account] | ||
| #[derive(Debug)] | ||
| pub struct MsgChunks { | ||
| pub type_url: String, | ||
| pub value: Vec<u8>, | ||
| } |
There was a problem hiding this comment.
This really should be zero copy or unchecked account IMO. Furthermore, rather than giving it a structure with type url and value, it’s better to treat it as a length-prefixed sequence of bytes. Those can than be decoded as proto to get Any message.
There was a problem hiding this comment.
the value is length prefixed but we would still need type_url right?
There was a problem hiding this comment.
No. The value would be an Any proto message so it would include type url.
There was a problem hiding this comment.
Oh i see, that makes sense.
|
Closing this since we would be using #171 . |
Since instructions to solana have a limit of 1232 bytes, we cannot send messages which exceed the limit. Since the update headers and other messages can easily exceed the limit, we have to split them into chunks and add it to an account so that it can be accessed later in the
delivermethod.Once the data in the account in executed by the
deliver, the account data ( which stored the msg chunks) would be cleared.