Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana-ibc: add Anchor tests to CI #22

Merged
merged 2 commits into from
Dec 11, 2023
Merged

solana-ibc: add Anchor tests to CI #22

merged 2 commits into from
Dec 11, 2023

Conversation

mina86
Copy link
Collaborator

@mina86 mina86 commented Oct 11, 2023

No description provided.

@mina86 mina86 requested a review from dhruvja October 11, 2023 23:52
Copy link
Collaborator

@dhruvja dhruvja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the CI, though it takes a long time to install anchor.

@ComposableFi ComposableFi locked and limited conversation to collaborators Oct 12, 2023
@ComposableFi ComposableFi unlocked this conversation Oct 12, 2023
@mina86
Copy link
Collaborator Author

mina86 commented Oct 12, 2023

Thanks. Due to the time let’s keep this as draft for now. Once 0.29 is released we can try using Docker image instead which cuts all the Solana and Anchor installation and build time.

@mina86 mina86 marked this pull request as draft October 12, 2023 15:29
@mina86 mina86 marked this pull request as ready for review December 10, 2023 16:33
@dhruvja
Copy link
Collaborator

dhruvja commented Dec 10, 2023

Any idea on how long it takes?

@mina86
Copy link
Collaborator Author

mina86 commented Dec 10, 2023

OK, so timing wise, when those three steps are run one after the
other:

  • anchor build takes 5′11″,
  • anchor build -- --features mocks takes 1′22″ and
  • anchor test --skip build takes 2′56″.

Altogether nine and a half minutes. That’s IMO long for CI but not
outrageously so. One way to improve this is by dropping the first
anchor build step. We’re building the codebase with and without
mocks feature in other steps so that should be mostly covered.

Interestingly, using Docker container is actually slower. Setting up
the container takes about a minute while with out caching setup,
setting up the environment takes just several seconds. Granted, when
Rust version changes the environment needs to be rebuilt (taking about
15 minutes) but that won’t happen too often.

@dhruvja
Copy link
Collaborator

dhruvja commented Dec 11, 2023

So since we are already running build, the additional test is 3 minutes which is quite good compared to outrageously long process of above 20 minutes ( anchor test ) it used to take before.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
@mina86 mina86 enabled auto-merge (squash) December 11, 2023 13:11
@mina86 mina86 merged commit a176c1f into master Dec 11, 2023
@mina86 mina86 deleted the mpn/a branch December 11, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants